[GitHub] [commons-compress] garydgregory commented on pull request #120: COMPRESS-542: Lazy allocation of SevenZArchiveEntry to prevent OOM on corrupt files

[GitBox <gi...@apache.org>]

garydgregory commented on pull request #120:
URL: https://github.com/apache/commons-compress/pull/120#issuecomment-668591114


   My biggest issue with this PR is that it is missing a unit test. Without a failing unit test, there is no way to know that this fixes anything or that a future change will regress to the previous behavior. Please add a test ;-)
   
   I also see a lot duplicate code like (5 times!)
   ```
   if (files[i] == null) {
         files[i] = new SevenZArchiveEntry();
   }
   ```
   which should be easily refactored.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org