[GitHub] tz70s commented on a change in pull request #4000: Put error message as tag into failed trace.

[GitBox <gi...@apache.org>]

tz70s commented on a change in pull request #4000: Put error message as tag into failed trace.
URL: https://github.com/apache/incubator-openwhisk/pull/4000#discussion_r215206495
 
 

 ##########
 File path: core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala
 ##########
 @@ -174,23 +175,24 @@ protected[actions] trait PrimitiveActions {
 
     val postedFuture = loadBalancer.publish(action, message)
 
-    postedFuture.flatMap { activeAckResponse =>
-      // successfully posted activation request to the message bus
-      transid.finished(this, startLoadbalancer)
-
+    postedFuture andThen {
+      case Success(_) => transid.finished(this, startLoadbalancer)
+      case Failure(e) => transid.failed(this, startLoadbalancer, e.getMessage, logLevel = ErrorLevel)
 
 Review comment:
   Thanks for reminding, we can use the default warn level.
   
   Should this get changed as well?
   https://github.com/apache/incubator-openwhisk/blob/0242a60aeb976d070abda76a8ac2aa7e3306e393/core/controller/src/main/scala/whisk/core/controller/Actions.scala#L292
   
   Or I can match exception types for different levels. However, I think logging here is quite redundant b.c. we've already logged this at `doInvoke`.
   
   BTW, in opentracing, there's no standardized warn tag provided, is this fine?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services