[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4745: [SegmentGeneratorConfig Cleanup] Replace checkTimeColumnValidityDuringGeneration with skipTimeValueCheck

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #4745: [SegmentGeneratorConfig Cleanup] Replace checkTimeColumnValidityDuringGeneration with skipTimeValueCheck
URL: https://github.com/apache/incubator-pinot/pull/4745#discussion_r339660614
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/generator/SegmentGeneratorConfig.java
 ##########
 @@ -112,7 +112,7 @@
   private String _simpleDateFormat = null;
   // Use on-heap or off-heap memory to generate index (currently only affect inverted index and star-tree v2)
   private boolean _onHeap = false;
-  private boolean _checkTimeColumnValidityDuringGeneration = true;
+  private boolean _skipTimeValueCheck = false;
 
 Review comment:
   +1 for default being true.
   The reason this check was added was because the time column check was done when the segment was pushed, and the segment push failed. The idea was to flag the error earlier since the segment is invalid and can never be pushed anyway

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org