You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Ignite TC Bot (Jira)" <ji...@apache.org> on 2020/07/20 12:11:00 UTC
[jira] [Commented] (IGNITE-13110) An option to validate field types
against SQL schema on key-value insert
[ https://issues.apache.org/jira/browse/IGNITE-13110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17161183#comment-17161183 ]
Ignite TC Bot commented on IGNITE-13110:
----------------------------------------
{panel:title=Branch: [pull/8055/head] Base: [master] : No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
{panel:title=Branch: [pull/8055/head] Base: [master] : New Tests (76)|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}
{color:#00008b}Queries 1{color} [[tests 68|https://ci.ignite.apache.org/viewLog.html?buildId=5475416]]
* {color:#013220}IgniteBinaryCacheQueryTestSuite: SqlFieldTypeValidationTypesTest.testClassInstanceError[13 type=class [I idx=true] - PASSED{color}
* {color:#013220}IgniteBinaryCacheQueryTestSuite: SqlFieldTypeValidationTypesTest.testError[13 type=class [I idx=true] - PASSED{color}
* {color:#013220}IgniteBinaryCacheQueryTestSuite: SqlFieldTypeValidationTypesTest.testClassInstanceError[12 type=class [I idx=false] - PASSED{color}
* {color:#013220}IgniteBinaryCacheQueryTestSuite: SqlFieldTypeValidationTypesTest.testError[12 type=class [I idx=false] - PASSED{color}
* {color:#013220}IgniteBinaryCacheQueryTestSuite: SqlFieldTypeValidationTypesTest.testClassInstanceError[3 type=class java.lang.String idx=true] - PASSED{color}
* {color:#013220}IgniteBinaryCacheQueryTestSuite: SqlFieldTypeValidationTypesTest.testError[3 type=class java.lang.String idx=true] - PASSED{color}
* {color:#013220}IgniteBinaryCacheQueryTestSuite: SqlFieldTypeValidationTypesTest.testClassInstanceError[5 type=class java.util.UUID idx=true] - PASSED{color}
* {color:#013220}IgniteBinaryCacheQueryTestSuite: SqlFieldTypeValidationTypesTest.testError[5 type=class java.util.UUID idx=true] - PASSED{color}
* {color:#013220}IgniteBinaryCacheQueryTestSuite: SqlFieldTypeValidationTypesTest.testClassInstanceError[4 type=class java.util.UUID idx=false] - PASSED{color}
* {color:#013220}IgniteBinaryCacheQueryTestSuite: SqlFieldTypeValidationTypesTest.testError[4 type=class java.util.UUID idx=false] - PASSED{color}
* {color:#013220}IgniteBinaryCacheQueryTestSuite: SqlFieldTypeValidationTypesTest.testClassInstanceError[0 type=class java.lang.Integer idx=false] - PASSED{color}
... and 57 new tests
{color:#00008b}Service Grid (legacy mode){color} [[tests 4|https://ci.ignite.apache.org/viewLog.html?buildId=5475423]]
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple [val1=DiscoveryEvent [evtNode=692515ca-65fb-4dc9-bdb8-1fe3d3ed41a1, topVer=0, msgTemplate=null, span=null, nodeId8=69c48b2c, msg=, type=NODE_JOINED, tstamp=1595232717546], val2=AffinityTopologyVersion [topVer=8366653243123417427, minorTopVer=0]]] - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple [val1=DiscoveryEvent [evtNode=692515ca-65fb-4dc9-bdb8-1fe3d3ed41a1, topVer=0, msgTemplate=null, span=null, nodeId8=69c48b2c, msg=, type=NODE_JOINED, tstamp=1595232717546], val2=AffinityTopologyVersion [topVer=8366653243123417427, minorTopVer=0]]] - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple [val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest [id=eea874b6371-ef472eb7-8ce8-432f-8951-b7a5a006be71, reqs=SingletonList [ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent [evtNode=739a829f-487e-49ae-a992-a5bd72f62aa7, topVer=0, msgTemplate=null, span=null, nodeId8=739a829f, msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1595232717546]], val2=AffinityTopologyVersion [topVer=-2971666190420602392, minorTopVer=0]]] - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple [val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest [id=eea874b6371-ef472eb7-8ce8-432f-8951-b7a5a006be71, reqs=SingletonList [ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent [evtNode=739a829f-487e-49ae-a992-a5bd72f62aa7, topVer=0, msgTemplate=null, span=null, nodeId8=739a829f, msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1595232717546]], val2=AffinityTopologyVersion [topVer=-2971666190420602392, minorTopVer=0]]] - PASSED{color}
{color:#00008b}Service Grid{color} [[tests 4|https://ci.ignite.apache.org/viewLog.html?buildId=5475422]]
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple [val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest [id=64f674b6371-3fa70bc9-50d4-468a-abcf-9a451ec71be7, reqs=SingletonList [ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent [evtNode=124003e3-5997-4ea1-aca2-4ec9bc7a669e, topVer=0, msgTemplate=null, span=null, nodeId8=124003e3, msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1595232710466]], val2=AffinityTopologyVersion [topVer=5508490707172436373, minorTopVer=0]]] - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple [val1=DiscoveryEvent [evtNode=a899e37e-13c7-495e-b8f2-b1d92b7213f4, topVer=0, msgTemplate=null, span=null, nodeId8=625fbf62, msg=, type=NODE_JOINED, tstamp=1595232710466], val2=AffinityTopologyVersion [topVer=-4873826889751359096, minorTopVer=0]]] - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.requestId[Test event=IgniteBiTuple [val1=DiscoveryEvent [evtNode=a899e37e-13c7-495e-b8f2-b1d92b7213f4, topVer=0, msgTemplate=null, span=null, nodeId8=625fbf62, msg=, type=NODE_JOINED, tstamp=1595232710466], val2=AffinityTopologyVersion [topVer=-4873826889751359096, minorTopVer=0]]] - PASSED{color}
* {color:#013220}IgniteServiceGridTestSuite: ServiceDeploymentProcessIdSelfTest.topologyVersion[Test event=IgniteBiTuple [val1=DiscoveryCustomEvent [customMsg=ServiceChangeBatchRequest [id=64f674b6371-3fa70bc9-50d4-468a-abcf-9a451ec71be7, reqs=SingletonList [ServiceUndeploymentRequest []]], affTopVer=null, super=DiscoveryEvent [evtNode=124003e3-5997-4ea1-aca2-4ec9bc7a669e, topVer=0, msgTemplate=null, span=null, nodeId8=124003e3, msg=null, type=DISCOVERY_CUSTOM_EVT, tstamp=1595232710466]], val2=AffinityTopologyVersion [topVer=5508490707172436373, minorTopVer=0]]] - PASSED{color}
{panel}
[TeamCity *--> Run :: All* Results|https://ci.ignite.apache.org/viewLog.html?buildId=5475443&buildTypeId=IgniteTests24Java8_RunAll]
> An option to validate field types against SQL schema on key-value insert
> ------------------------------------------------------------------------
>
> Key: IGNITE-13110
> URL: https://issues.apache.org/jira/browse/IGNITE-13110
> Project: Ignite
> Issue Type: Bug
> Reporter: Sergey Kalashnikov
> Assignee: Sergey Kalashnikov
> Priority: Major
> Fix For: 2.9
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Let's add a configurable option to prevent insertion of key-value pairs that aren't compatible with SQL schema.
> An option can be added on {{SqlConfiguration}} level or even per {{QueryEntity}}.
> The checks can be performed within the existing {{GridQueryTypeDescriptor#validateKeyAndValue}} facility that seems to be well suited for this task.
> This addition will prevent the problems when values successfully added to the cache later produce errors when queried with SQL.
> See discussion : http://apache-ignite-developers.2346864.n4.nabble.com/Prevent-insertion-of-cache-entry-if-the-binary-field-type-and-the-type-of-the-query-entity-do-not-ma-td47678.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)