You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/13 09:13:09 UTC
[GitHub] [skywalking] codecodesam opened a new issue, #9785: [Bug] EndpointRelation#prepare NPE
codecodesam opened a new issue, #9785:
URL: https://github.com/apache/skywalking/issues/9785
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues.
### Apache SkyWalking Component
OAP server (apache/skywalking)
### What happened
 Server version: 9.1.0;
Situation:org.apache.skywalking.oap.server.core.source.EndpointRelation#prepare(101) has a NPE;
Frequency:a most of segment
### What you expected to happen
I review the code and find a place that maybe cause EndpointRelation.serviceLayer Null;
```
// org.apache.skywalking.oap.server.analyzer.provider.trace.parser.listener.EndpointDepFromCrossThreadAnalysisListener#parseRefForEndpointDependency
if (isMQ || config.getUninstrumentedGatewaysConfig()
.isAddressConfiguredAsGateway(networkAddressUsedAtPeer)) {
sourceBuilder.setSourceServiceName(networkAddressUsedAtPeer);
sourceBuilder.setSourceEndpointOwnerServiceName(reference.getParentService());
sourceBuilder.setSourceServiceInstanceName(networkAddressUsedAtPeer);
if (isMQ) {
sourceBuilder.setSourceLayer(Layer.VIRTUAL_MQ);
} else {
sourceBuilder.setSourceLayer(Layer.VIRTUAL_GATEWAY);
}
}
```
sourceBuilder did not set a attribute (**sourceEndpointOwnerServiceLayer**);
org.apache.skywalking.oap.server.analyzer.provider.trace.parser.listener.RPCTrafficSourceBuilder#toEndpointRelation
- sourceEndpointOwnerServiceName is not null,but sourceEndpointOwnerServiceLayer is null
### How to reproduce
make the condition is true
```
isMQ || config.getUninstrumentedGatewaysConfig()
.isAddressConfiguredAsGateway(networkAddressUsedAtPeer)
```
### Anything else
_No response_
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9785: [Bug] EndpointRelation#prepare NPE
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9785:
URL: https://github.com/apache/skywalking/issues/9785#issuecomment-1277296500
Please search the change log and compare the latest codes before submitting a bug.
This has been fixed several months ago, https://github.com/apache/skywalking/pull/9300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #9785: [Bug] EndpointRelation#prepare NPE
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #9785: [Bug] EndpointRelation#prepare NPE
URL: https://github.com/apache/skywalking/issues/9785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org