[GitHub] [ignite-3] lowka commented on a diff in pull request #2368: IGNITE-19877 Sql. Fix not allowed CAST with dynamic params

["lowka (via GitHub)" <gi...@apache.org>]

lowka commented on code in PR #2368:
URL: https://github.com/apache/ignite-3/pull/2368#discussion_r1285421471


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItPublicApiColocationTest.java:
##########
@@ -284,6 +284,7 @@ private static String sqlTypeName(NativeTypeSpec type) {
             case INT32:
                 return "integer";
             case INT64:
+            case NUMBER:

Review Comment:
   I thin this is not correct because there is no SQL type for NativeType.NUMBER + a number is BigInteger



##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/table/ItPublicApiColocationTest.java:
##########
@@ -284,6 +284,7 @@ private static String sqlTypeName(NativeTypeSpec type) {
             case INT32:
                 return "integer";
             case INT64:
+            case NUMBER:

Review Comment:
   I think this is not correct because there is no SQL type for NativeType.NUMBER + a number is BigInteger



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org