[GitHub] asdf2014 commented on a change in pull request #6868: Fix deadlock in DruidStatement & DruidConnection

[GitBox <gi...@apache.org>]

asdf2014 commented on a change in pull request #6868: Fix deadlock in DruidStatement & DruidConnection
URL: https://github.com/apache/incubator-druid/pull/6868#discussion_r248147536
 
 

 ##########
 File path: sql/src/main/java/org/apache/druid/sql/avatica/DruidConnection.java
 ##########
 @@ -63,7 +63,7 @@ public DruidConnection(final String connectionId, final int maxStatements, final
     this.connectionId = Preconditions.checkNotNull(connectionId);
     this.maxStatements = maxStatements;
     this.context = ImmutableMap.copyOf(context);
-    this.statements = new HashMap<>();
+    this.statements = new ConcurrentHashMap<>();
 
 Review comment:
   Maybe we should remove the `GuardedBy` annotation from the `statements` instance and consider removing all `synchronized (statements) {...}` clauses since we use `ConcurrentHashMap` instead of `HashMap`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org