You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/23 06:21:23 UTC
[GitHub] [flink] KarmaGYZ opened a new pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
KarmaGYZ opened a new pull request #11873:
URL: https://github.com/apache/flink/pull/11873
…VertexID and attemptNumber
## What is the purpose of the change
Refactor the ExecutionAttemptID to consist of ExecutionVertexID and attemptNumber.
## Brief change log
Refactor the ExecutionAttemptID to consist of ExecutionVertexID and attemptNumber.
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: probably yes
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: probably yes
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618208681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161570750",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790683",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=183",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1a8bf3517bd92eb1af532182377cb9f4b57da6b8 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161570750) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106)
* 223dc2f79c617c84771b333a9b9f4ec0b5b81a31 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161790683) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=183)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618208681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161570750",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790683",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=183",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=253",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162037701",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "378634c7f6c526e73592813e4957a017d192cc5f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4320",
"triggerID" : "378634c7f6c526e73592813e4957a017d192cc5f",
"triggerType" : "PUSH"
}, {
"hash" : "ee878059addc8b6938d57b300e49477b52b652ac",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ee878059addc8b6938d57b300e49477b52b652ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 378634c7f6c526e73592813e4957a017d192cc5f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4320)
* ee878059addc8b6938d57b300e49477b52b652ac UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618208681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161570750",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790683",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=183",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=253",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162037701",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5534ebe0d1ff7acba0f3ddd16770bc08908e301b Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162037701) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=253)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on a change in pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #11873:
URL: https://github.com/apache/flink/pull/11873#discussion_r471210685
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionAttemptID.java
##########
@@ -18,33 +18,77 @@
package org.apache.flink.runtime.executiongraph;
-import org.apache.flink.util.AbstractID;
+import org.apache.flink.annotation.VisibleForTesting;
+import org.apache.flink.runtime.scheduler.strategy.ExecutionVertexID;
import org.apache.flink.shaded.netty4.io.netty.buffer.ByteBuf;
+import org.apache.flink.util.Preconditions;
/**
* Unique identifier for the attempt to execute a tasks. Multiple attempts happen
* in cases of failures and recovery.
*/
-public class ExecutionAttemptID extends AbstractID {
+public class ExecutionAttemptID implements java.io.Serializable {
private static final long serialVersionUID = -1169683445778281344L;
+ private final ExecutionVertexID executionVertexID;
+ private final int attemptNumber;
+
+ /**
+ * Get a random execution attempt id.
+ */
public ExecutionAttemptID() {
+ this(new ExecutionVertexID(), 0);
}
- public ExecutionAttemptID(long lowerPart, long upperPart) {
- super(lowerPart, upperPart);
+ public ExecutionAttemptID(ExecutionVertexID executionVertexID, int attemptNumber) {
+ Preconditions.checkState(attemptNumber >= 0);
+ this.executionVertexID = Preconditions.checkNotNull(executionVertexID);
+ this.attemptNumber = attemptNumber;
}
public void writeTo(ByteBuf buf) {
- buf.writeLong(this.lowerPart);
- buf.writeLong(this.upperPart);
+ executionVertexID.writeTo(buf);
+ buf.writeInt(this.attemptNumber);
}
public static ExecutionAttemptID fromByteBuf(ByteBuf buf) {
- long lower = buf.readLong();
- long upper = buf.readLong();
- return new ExecutionAttemptID(lower, upper);
+ final ExecutionVertexID executionVertexID = ExecutionVertexID.fromByteBuf(buf);
+ final int attemptNumber = buf.readInt();
+ return new ExecutionAttemptID(executionVertexID, attemptNumber);
+ }
+
+ @VisibleForTesting
+ public int getAttemptNumber() {
+ return attemptNumber;
+ }
+
+ @VisibleForTesting
+ public ExecutionVertexID getExecutionVertexID() {
+ return executionVertexID;
+ }
+
+ @Override
+ public boolean equals(Object obj) {
+ if (obj == this) {
+ return true;
+ } else if (obj != null && obj.getClass() == getClass()) {
+ ExecutionAttemptID that = (ExecutionAttemptID) obj;
+ return that.executionVertexID.equals(this.executionVertexID)
+ && that.attemptNumber == this.attemptNumber;
+ } else {
+ return false;
+ }
+ }
+
+ @Override
+ public int hashCode() {
+ return this.executionVertexID.hashCode() ^ this.attemptNumber;
Review comment:
Good point!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618208681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161570750",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790683",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=183",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 223dc2f79c617c84771b333a9b9f4ec0b5b81a31 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161790683) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=183)
* 5534ebe0d1ff7acba0f3ddd16770bc08908e301b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618208681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161570750",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790683",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=183",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 223dc2f79c617c84771b333a9b9f4ec0b5b81a31 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161790683) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=183)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618208681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161570750",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790683",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=183",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=253",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162037701",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "378634c7f6c526e73592813e4957a017d192cc5f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4320",
"triggerID" : "378634c7f6c526e73592813e4957a017d192cc5f",
"triggerType" : "PUSH"
}, {
"hash" : "ee878059addc8b6938d57b300e49477b52b652ac",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4666",
"triggerID" : "ee878059addc8b6938d57b300e49477b52b652ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 378634c7f6c526e73592813e4957a017d192cc5f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4320)
* ee878059addc8b6938d57b300e49477b52b652ac Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4666)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on issue #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618208681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161570750",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1a8bf3517bd92eb1af532182377cb9f4b57da6b8 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161570750) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618208681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161570750",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790683",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=183",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=253",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162037701",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "378634c7f6c526e73592813e4957a017d192cc5f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4320",
"triggerID" : "378634c7f6c526e73592813e4957a017d192cc5f",
"triggerType" : "PUSH"
}, {
"hash" : "ee878059addc8b6938d57b300e49477b52b652ac",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4666",
"triggerID" : "ee878059addc8b6938d57b300e49477b52b652ac",
"triggerType" : "PUSH"
}, {
"hash" : "86328bd6247ecd10a2b7a00a83b41a8269cf60cf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4674",
"triggerID" : "86328bd6247ecd10a2b7a00a83b41a8269cf60cf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86328bd6247ecd10a2b7a00a83b41a8269cf60cf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4674)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on a change in pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on a change in pull request #11873:
URL: https://github.com/apache/flink/pull/11873#discussion_r471221474
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionAttemptID.java
##########
@@ -18,33 +18,77 @@
package org.apache.flink.runtime.executiongraph;
-import org.apache.flink.util.AbstractID;
+import org.apache.flink.annotation.VisibleForTesting;
+import org.apache.flink.runtime.scheduler.strategy.ExecutionVertexID;
import org.apache.flink.shaded.netty4.io.netty.buffer.ByteBuf;
+import org.apache.flink.util.Preconditions;
/**
* Unique identifier for the attempt to execute a tasks. Multiple attempts happen
* in cases of failures and recovery.
*/
-public class ExecutionAttemptID extends AbstractID {
+public class ExecutionAttemptID implements java.io.Serializable {
private static final long serialVersionUID = -1169683445778281344L;
+ private final ExecutionVertexID executionVertexID;
+ private final int attemptNumber;
+
+ /**
+ * Get a random execution attempt id.
+ */
public ExecutionAttemptID() {
Review comment:
Makes sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618208681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161570750",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790683",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=183",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=253",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162037701",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "378634c7f6c526e73592813e4957a017d192cc5f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4320",
"triggerID" : "378634c7f6c526e73592813e4957a017d192cc5f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 378634c7f6c526e73592813e4957a017d192cc5f Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4320)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618208681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161570750",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1a8bf3517bd92eb1af532182377cb9f4b57da6b8 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161570750) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106)
* 223dc2f79c617c84771b333a9b9f4ec0b5b81a31 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618208681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161570750",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790683",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=183",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=253",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162037701",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "378634c7f6c526e73592813e4957a017d192cc5f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4320",
"triggerID" : "378634c7f6c526e73592813e4957a017d192cc5f",
"triggerType" : "PUSH"
}, {
"hash" : "ee878059addc8b6938d57b300e49477b52b652ac",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4666",
"triggerID" : "ee878059addc8b6938d57b300e49477b52b652ac",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee878059addc8b6938d57b300e49477b52b652ac Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4666)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on issue #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618204287
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 1a8bf3517bd92eb1af532182377cb9f4b57da6b8 (Thu Apr 23 06:24:18 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618208681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161570750",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790683",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=183",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=253",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162037701",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5534ebe0d1ff7acba0f3ddd16770bc08908e301b Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162037701) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=253)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618208681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161570750",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790683",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=183",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=253",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162037701",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "378634c7f6c526e73592813e4957a017d192cc5f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4320",
"triggerID" : "378634c7f6c526e73592813e4957a017d192cc5f",
"triggerType" : "PUSH"
}, {
"hash" : "ee878059addc8b6938d57b300e49477b52b652ac",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4666",
"triggerID" : "ee878059addc8b6938d57b300e49477b52b652ac",
"triggerType" : "PUSH"
}, {
"hash" : "86328bd6247ecd10a2b7a00a83b41a8269cf60cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4674",
"triggerID" : "86328bd6247ecd10a2b7a00a83b41a8269cf60cf",
"triggerType" : "PUSH"
}, {
"hash" : "04ebeee8b4a19b2aafee9e57a746522cd2c9654f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4700",
"triggerID" : "04ebeee8b4a19b2aafee9e57a746522cd2c9654f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 04ebeee8b4a19b2aafee9e57a746522cd2c9654f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4700)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on issue #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618208681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161570750",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1a8bf3517bd92eb1af532182377cb9f4b57da6b8 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161570750) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618208681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161570750",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790683",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=183",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=253",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162037701",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "378634c7f6c526e73592813e4957a017d192cc5f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4320",
"triggerID" : "378634c7f6c526e73592813e4957a017d192cc5f",
"triggerType" : "PUSH"
}, {
"hash" : "ee878059addc8b6938d57b300e49477b52b652ac",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4666",
"triggerID" : "ee878059addc8b6938d57b300e49477b52b652ac",
"triggerType" : "PUSH"
}, {
"hash" : "86328bd6247ecd10a2b7a00a83b41a8269cf60cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4674",
"triggerID" : "86328bd6247ecd10a2b7a00a83b41a8269cf60cf",
"triggerType" : "PUSH"
}, {
"hash" : "04ebeee8b4a19b2aafee9e57a746522cd2c9654f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4700",
"triggerID" : "04ebeee8b4a19b2aafee9e57a746522cd2c9654f",
"triggerType" : "PUSH"
}, {
"hash" : "04ebeee8b4a19b2aafee9e57a746522cd2c9654f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4782",
"triggerID" : "655406517",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 04ebeee8b4a19b2aafee9e57a746522cd2c9654f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4700) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4782)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618208681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161570750",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790683",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=183",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=253",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162037701",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "378634c7f6c526e73592813e4957a017d192cc5f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4320",
"triggerID" : "378634c7f6c526e73592813e4957a017d192cc5f",
"triggerType" : "PUSH"
}, {
"hash" : "ee878059addc8b6938d57b300e49477b52b652ac",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4666",
"triggerID" : "ee878059addc8b6938d57b300e49477b52b652ac",
"triggerType" : "PUSH"
}, {
"hash" : "86328bd6247ecd10a2b7a00a83b41a8269cf60cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4674",
"triggerID" : "86328bd6247ecd10a2b7a00a83b41a8269cf60cf",
"triggerType" : "PUSH"
}, {
"hash" : "04ebeee8b4a19b2aafee9e57a746522cd2c9654f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4700",
"triggerID" : "04ebeee8b4a19b2aafee9e57a746522cd2c9654f",
"triggerType" : "PUSH"
}, {
"hash" : "04ebeee8b4a19b2aafee9e57a746522cd2c9654f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4782",
"triggerID" : "655406517",
"triggerType" : "MANUAL"
}, {
"hash" : "04ebeee8b4a19b2aafee9e57a746522cd2c9654f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4700",
"triggerID" : "655406517",
"triggerType" : "MANUAL"
}, {
"hash" : "ae7da66548039da54cf4ac664c517e2bb8eab68f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5579",
"triggerID" : "ae7da66548039da54cf4ac664c517e2bb8eab68f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 04ebeee8b4a19b2aafee9e57a746522cd2c9654f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4782) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4700)
* ae7da66548039da54cf4ac664c517e2bb8eab68f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5579)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618208681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161570750",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790683",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=183",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=253",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162037701",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "378634c7f6c526e73592813e4957a017d192cc5f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4320",
"triggerID" : "378634c7f6c526e73592813e4957a017d192cc5f",
"triggerType" : "PUSH"
}, {
"hash" : "ee878059addc8b6938d57b300e49477b52b652ac",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4666",
"triggerID" : "ee878059addc8b6938d57b300e49477b52b652ac",
"triggerType" : "PUSH"
}, {
"hash" : "86328bd6247ecd10a2b7a00a83b41a8269cf60cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4674",
"triggerID" : "86328bd6247ecd10a2b7a00a83b41a8269cf60cf",
"triggerType" : "PUSH"
}, {
"hash" : "04ebeee8b4a19b2aafee9e57a746522cd2c9654f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4700",
"triggerID" : "04ebeee8b4a19b2aafee9e57a746522cd2c9654f",
"triggerType" : "PUSH"
}, {
"hash" : "04ebeee8b4a19b2aafee9e57a746522cd2c9654f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4782",
"triggerID" : "655406517",
"triggerType" : "MANUAL"
}, {
"hash" : "04ebeee8b4a19b2aafee9e57a746522cd2c9654f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4700",
"triggerID" : "655406517",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 04ebeee8b4a19b2aafee9e57a746522cd2c9654f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4782) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4700)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618208681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161570750",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790683",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=183",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=253",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162037701",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "378634c7f6c526e73592813e4957a017d192cc5f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4320",
"triggerID" : "378634c7f6c526e73592813e4957a017d192cc5f",
"triggerType" : "PUSH"
}, {
"hash" : "ee878059addc8b6938d57b300e49477b52b652ac",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4666",
"triggerID" : "ee878059addc8b6938d57b300e49477b52b652ac",
"triggerType" : "PUSH"
}, {
"hash" : "86328bd6247ecd10a2b7a00a83b41a8269cf60cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4674",
"triggerID" : "86328bd6247ecd10a2b7a00a83b41a8269cf60cf",
"triggerType" : "PUSH"
}, {
"hash" : "04ebeee8b4a19b2aafee9e57a746522cd2c9654f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4700",
"triggerID" : "04ebeee8b4a19b2aafee9e57a746522cd2c9654f",
"triggerType" : "PUSH"
}, {
"hash" : "04ebeee8b4a19b2aafee9e57a746522cd2c9654f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4782",
"triggerID" : "655406517",
"triggerType" : "MANUAL"
}, {
"hash" : "04ebeee8b4a19b2aafee9e57a746522cd2c9654f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4700",
"triggerID" : "655406517",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 04ebeee8b4a19b2aafee9e57a746522cd2c9654f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4782) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4700)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618208681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161570750",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790683",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=183",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=253",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162037701",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "378634c7f6c526e73592813e4957a017d192cc5f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4320",
"triggerID" : "378634c7f6c526e73592813e4957a017d192cc5f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5534ebe0d1ff7acba0f3ddd16770bc08908e301b Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162037701) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=253)
* 378634c7f6c526e73592813e4957a017d192cc5f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4320)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on a change in pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #11873:
URL: https://github.com/apache/flink/pull/11873#discussion_r471218269
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionAttemptID.java
##########
@@ -18,33 +18,77 @@
package org.apache.flink.runtime.executiongraph;
-import org.apache.flink.util.AbstractID;
+import org.apache.flink.annotation.VisibleForTesting;
+import org.apache.flink.runtime.scheduler.strategy.ExecutionVertexID;
import org.apache.flink.shaded.netty4.io.netty.buffer.ByteBuf;
+import org.apache.flink.util.Preconditions;
/**
* Unique identifier for the attempt to execute a tasks. Multiple attempts happen
* in cases of failures and recovery.
*/
-public class ExecutionAttemptID extends AbstractID {
+public class ExecutionAttemptID implements java.io.Serializable {
private static final long serialVersionUID = -1169683445778281344L;
+ private final ExecutionVertexID executionVertexID;
+ private final int attemptNumber;
+
+ /**
+ * Get a random execution attempt id.
+ */
public ExecutionAttemptID() {
Review comment:
Yes, that's a good point. However, it is currently used by production code and a lot of testing code paths. I would move this issue out of the scope of this PR. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618208681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161570750",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790683",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=183",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=253",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162037701",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "378634c7f6c526e73592813e4957a017d192cc5f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4320",
"triggerID" : "378634c7f6c526e73592813e4957a017d192cc5f",
"triggerType" : "PUSH"
}, {
"hash" : "ee878059addc8b6938d57b300e49477b52b652ac",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4666",
"triggerID" : "ee878059addc8b6938d57b300e49477b52b652ac",
"triggerType" : "PUSH"
}, {
"hash" : "86328bd6247ecd10a2b7a00a83b41a8269cf60cf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4674",
"triggerID" : "86328bd6247ecd10a2b7a00a83b41a8269cf60cf",
"triggerType" : "PUSH"
}, {
"hash" : "04ebeee8b4a19b2aafee9e57a746522cd2c9654f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4700",
"triggerID" : "04ebeee8b4a19b2aafee9e57a746522cd2c9654f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86328bd6247ecd10a2b7a00a83b41a8269cf60cf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4674)
* 04ebeee8b4a19b2aafee9e57a746522cd2c9654f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4700)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618208681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161570750",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790683",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=183",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=253",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162037701",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "378634c7f6c526e73592813e4957a017d192cc5f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4320",
"triggerID" : "378634c7f6c526e73592813e4957a017d192cc5f",
"triggerType" : "PUSH"
}, {
"hash" : "ee878059addc8b6938d57b300e49477b52b652ac",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4666",
"triggerID" : "ee878059addc8b6938d57b300e49477b52b652ac",
"triggerType" : "PUSH"
}, {
"hash" : "86328bd6247ecd10a2b7a00a83b41a8269cf60cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4674",
"triggerID" : "86328bd6247ecd10a2b7a00a83b41a8269cf60cf",
"triggerType" : "PUSH"
}, {
"hash" : "04ebeee8b4a19b2aafee9e57a746522cd2c9654f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4700",
"triggerID" : "04ebeee8b4a19b2aafee9e57a746522cd2c9654f",
"triggerType" : "PUSH"
}, {
"hash" : "04ebeee8b4a19b2aafee9e57a746522cd2c9654f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4782",
"triggerID" : "655406517",
"triggerType" : "MANUAL"
}, {
"hash" : "04ebeee8b4a19b2aafee9e57a746522cd2c9654f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4700",
"triggerID" : "655406517",
"triggerType" : "MANUAL"
}, {
"hash" : "ae7da66548039da54cf4ac664c517e2bb8eab68f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5579",
"triggerID" : "ae7da66548039da54cf4ac664c517e2bb8eab68f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ae7da66548039da54cf4ac664c517e2bb8eab68f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5579)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618208681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161570750",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790683",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=183",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 223dc2f79c617c84771b333a9b9f4ec0b5b81a31 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161790683) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=183)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618208681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161570750",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790683",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=183",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=253",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162037701",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "378634c7f6c526e73592813e4957a017d192cc5f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4320",
"triggerID" : "378634c7f6c526e73592813e4957a017d192cc5f",
"triggerType" : "PUSH"
}, {
"hash" : "ee878059addc8b6938d57b300e49477b52b652ac",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4666",
"triggerID" : "ee878059addc8b6938d57b300e49477b52b652ac",
"triggerType" : "PUSH"
}, {
"hash" : "86328bd6247ecd10a2b7a00a83b41a8269cf60cf",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4674",
"triggerID" : "86328bd6247ecd10a2b7a00a83b41a8269cf60cf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee878059addc8b6938d57b300e49477b52b652ac Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4666)
* 86328bd6247ecd10a2b7a00a83b41a8269cf60cf Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4674)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk merged pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
zhuzhurk merged pull request #11873:
URL: https://github.com/apache/flink/pull/11873
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618208681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161570750",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790683",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=183",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=253",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162037701",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "378634c7f6c526e73592813e4957a017d192cc5f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4320",
"triggerID" : "378634c7f6c526e73592813e4957a017d192cc5f",
"triggerType" : "PUSH"
}, {
"hash" : "ee878059addc8b6938d57b300e49477b52b652ac",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4666",
"triggerID" : "ee878059addc8b6938d57b300e49477b52b652ac",
"triggerType" : "PUSH"
}, {
"hash" : "86328bd6247ecd10a2b7a00a83b41a8269cf60cf",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4674",
"triggerID" : "86328bd6247ecd10a2b7a00a83b41a8269cf60cf",
"triggerType" : "PUSH"
}, {
"hash" : "04ebeee8b4a19b2aafee9e57a746522cd2c9654f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "04ebeee8b4a19b2aafee9e57a746522cd2c9654f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 86328bd6247ecd10a2b7a00a83b41a8269cf60cf Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4674)
* 04ebeee8b4a19b2aafee9e57a746522cd2c9654f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618208681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161570750",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790683",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=183",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=253",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162037701",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "378634c7f6c526e73592813e4957a017d192cc5f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4320",
"triggerID" : "378634c7f6c526e73592813e4957a017d192cc5f",
"triggerType" : "PUSH"
}, {
"hash" : "ee878059addc8b6938d57b300e49477b52b652ac",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4666",
"triggerID" : "ee878059addc8b6938d57b300e49477b52b652ac",
"triggerType" : "PUSH"
}, {
"hash" : "86328bd6247ecd10a2b7a00a83b41a8269cf60cf",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "86328bd6247ecd10a2b7a00a83b41a8269cf60cf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee878059addc8b6938d57b300e49477b52b652ac Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4666)
* 86328bd6247ecd10a2b7a00a83b41a8269cf60cf UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618208681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161570750",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790683",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=183",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=253",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162037701",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "378634c7f6c526e73592813e4957a017d192cc5f",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4320",
"triggerID" : "378634c7f6c526e73592813e4957a017d192cc5f",
"triggerType" : "PUSH"
}, {
"hash" : "ee878059addc8b6938d57b300e49477b52b652ac",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4666",
"triggerID" : "ee878059addc8b6938d57b300e49477b52b652ac",
"triggerType" : "PUSH"
}, {
"hash" : "86328bd6247ecd10a2b7a00a83b41a8269cf60cf",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4674",
"triggerID" : "86328bd6247ecd10a2b7a00a83b41a8269cf60cf",
"triggerType" : "PUSH"
}, {
"hash" : "04ebeee8b4a19b2aafee9e57a746522cd2c9654f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4700",
"triggerID" : "04ebeee8b4a19b2aafee9e57a746522cd2c9654f",
"triggerType" : "PUSH"
}, {
"hash" : "04ebeee8b4a19b2aafee9e57a746522cd2c9654f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4782",
"triggerID" : "655406517",
"triggerType" : "MANUAL"
}, {
"hash" : "04ebeee8b4a19b2aafee9e57a746522cd2c9654f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4700",
"triggerID" : "655406517",
"triggerType" : "MANUAL"
}, {
"hash" : "ae7da66548039da54cf4ac664c517e2bb8eab68f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ae7da66548039da54cf4ac664c517e2bb8eab68f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 04ebeee8b4a19b2aafee9e57a746522cd2c9654f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4782) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4700)
* ae7da66548039da54cf4ac664c517e2bb8eab68f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on pull request #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-674727866
Thanks for the review @zhuzhurk . I've updated the PR. The lastest version passes all the e2e tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618208681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161570750",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790683",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=183",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=253",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162037701",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "378634c7f6c526e73592813e4957a017d192cc5f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "378634c7f6c526e73592813e4957a017d192cc5f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5534ebe0d1ff7acba0f3ddd16770bc08908e301b Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162037701) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=253)
* 378634c7f6c526e73592813e4957a017d192cc5f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618208681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161570750",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161790683",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=183",
"triggerID" : "223dc2f79c617c84771b333a9b9f4ec0b5b81a31",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=253",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
}, {
"hash" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162037701",
"triggerID" : "5534ebe0d1ff7acba0f3ddd16770bc08908e301b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 223dc2f79c617c84771b333a9b9f4ec0b5b81a31 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/161790683) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=183)
* 5534ebe0d1ff7acba0f3ddd16770bc08908e301b Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/162037701) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=253)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zhuzhurk commented on a change in pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
zhuzhurk commented on a change in pull request #11873:
URL: https://github.com/apache/flink/pull/11873#discussion_r467667602
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionAttemptID.java
##########
@@ -18,33 +18,77 @@
package org.apache.flink.runtime.executiongraph;
-import org.apache.flink.util.AbstractID;
+import org.apache.flink.annotation.VisibleForTesting;
+import org.apache.flink.runtime.scheduler.strategy.ExecutionVertexID;
import org.apache.flink.shaded.netty4.io.netty.buffer.ByteBuf;
+import org.apache.flink.util.Preconditions;
/**
* Unique identifier for the attempt to execute a tasks. Multiple attempts happen
* in cases of failures and recovery.
*/
-public class ExecutionAttemptID extends AbstractID {
+public class ExecutionAttemptID implements java.io.Serializable {
private static final long serialVersionUID = -1169683445778281344L;
+ private final ExecutionVertexID executionVertexID;
+ private final int attemptNumber;
+
+ /**
+ * Get a random execution attempt id.
+ */
public ExecutionAttemptID() {
+ this(new ExecutionVertexID(), 0);
}
- public ExecutionAttemptID(long lowerPart, long upperPart) {
- super(lowerPart, upperPart);
+ public ExecutionAttemptID(ExecutionVertexID executionVertexID, int attemptNumber) {
+ Preconditions.checkState(attemptNumber >= 0);
+ this.executionVertexID = Preconditions.checkNotNull(executionVertexID);
+ this.attemptNumber = attemptNumber;
}
public void writeTo(ByteBuf buf) {
- buf.writeLong(this.lowerPart);
- buf.writeLong(this.upperPart);
+ executionVertexID.writeTo(buf);
+ buf.writeInt(this.attemptNumber);
}
public static ExecutionAttemptID fromByteBuf(ByteBuf buf) {
- long lower = buf.readLong();
- long upper = buf.readLong();
- return new ExecutionAttemptID(lower, upper);
+ final ExecutionVertexID executionVertexID = ExecutionVertexID.fromByteBuf(buf);
+ final int attemptNumber = buf.readInt();
+ return new ExecutionAttemptID(executionVertexID, attemptNumber);
+ }
+
+ @VisibleForTesting
+ public int getAttemptNumber() {
+ return attemptNumber;
+ }
+
+ @VisibleForTesting
+ public ExecutionVertexID getExecutionVertexID() {
Review comment:
NIT: `getExecutionVertexId` would be better than `getExecutionVertexID`
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionAttemptID.java
##########
@@ -18,33 +18,77 @@
package org.apache.flink.runtime.executiongraph;
-import org.apache.flink.util.AbstractID;
+import org.apache.flink.annotation.VisibleForTesting;
+import org.apache.flink.runtime.scheduler.strategy.ExecutionVertexID;
import org.apache.flink.shaded.netty4.io.netty.buffer.ByteBuf;
+import org.apache.flink.util.Preconditions;
/**
* Unique identifier for the attempt to execute a tasks. Multiple attempts happen
* in cases of failures and recovery.
*/
-public class ExecutionAttemptID extends AbstractID {
+public class ExecutionAttemptID implements java.io.Serializable {
private static final long serialVersionUID = -1169683445778281344L;
+ private final ExecutionVertexID executionVertexID;
+ private final int attemptNumber;
+
+ /**
+ * Get a random execution attempt id.
+ */
public ExecutionAttemptID() {
+ this(new ExecutionVertexID(), 0);
}
- public ExecutionAttemptID(long lowerPart, long upperPart) {
- super(lowerPart, upperPart);
+ public ExecutionAttemptID(ExecutionVertexID executionVertexID, int attemptNumber) {
+ Preconditions.checkState(attemptNumber >= 0);
+ this.executionVertexID = Preconditions.checkNotNull(executionVertexID);
+ this.attemptNumber = attemptNumber;
}
public void writeTo(ByteBuf buf) {
- buf.writeLong(this.lowerPart);
- buf.writeLong(this.upperPart);
+ executionVertexID.writeTo(buf);
+ buf.writeInt(this.attemptNumber);
}
public static ExecutionAttemptID fromByteBuf(ByteBuf buf) {
- long lower = buf.readLong();
- long upper = buf.readLong();
- return new ExecutionAttemptID(lower, upper);
+ final ExecutionVertexID executionVertexID = ExecutionVertexID.fromByteBuf(buf);
+ final int attemptNumber = buf.readInt();
+ return new ExecutionAttemptID(executionVertexID, attemptNumber);
+ }
+
+ @VisibleForTesting
+ public int getAttemptNumber() {
+ return attemptNumber;
+ }
+
+ @VisibleForTesting
+ public ExecutionVertexID getExecutionVertexID() {
+ return executionVertexID;
+ }
+
+ @Override
+ public boolean equals(Object obj) {
+ if (obj == this) {
+ return true;
+ } else if (obj != null && obj.getClass() == getClass()) {
+ ExecutionAttemptID that = (ExecutionAttemptID) obj;
+ return that.executionVertexID.equals(this.executionVertexID)
+ && that.attemptNumber == this.attemptNumber;
+ } else {
+ return false;
+ }
+ }
+
+ @Override
+ public int hashCode() {
+ return this.executionVertexID.hashCode() ^ this.attemptNumber;
Review comment:
I'd prefer `this.executionVertexID.hashCode() * 31 + this.attemptNumber`.
This is because `attemptNumber == 0` is very common and can result in the same hash code.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionAttemptID.java
##########
@@ -18,33 +18,77 @@
package org.apache.flink.runtime.executiongraph;
-import org.apache.flink.util.AbstractID;
+import org.apache.flink.annotation.VisibleForTesting;
+import org.apache.flink.runtime.scheduler.strategy.ExecutionVertexID;
import org.apache.flink.shaded.netty4.io.netty.buffer.ByteBuf;
+import org.apache.flink.util.Preconditions;
/**
* Unique identifier for the attempt to execute a tasks. Multiple attempts happen
* in cases of failures and recovery.
*/
-public class ExecutionAttemptID extends AbstractID {
+public class ExecutionAttemptID implements java.io.Serializable {
private static final long serialVersionUID = -1169683445778281344L;
+ private final ExecutionVertexID executionVertexID;
+ private final int attemptNumber;
+
+ /**
+ * Get a random execution attempt id.
+ */
public ExecutionAttemptID() {
Review comment:
This constructor is for tests only. Could we introduce a test util method `ExecutionGraphTestUtils#createRandomExecutionAttemptId()`? The returned id consists of a random `ExecutionVertexId` as well as a random `attemptNumber`. I think it better suites the tests which wants a random `ExecutionAttemptID`. And we can also avoid to add a test-only code path in production.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ExecutionAttemptID.java
##########
@@ -18,33 +18,77 @@
package org.apache.flink.runtime.executiongraph;
-import org.apache.flink.util.AbstractID;
+import org.apache.flink.annotation.VisibleForTesting;
+import org.apache.flink.runtime.scheduler.strategy.ExecutionVertexID;
import org.apache.flink.shaded.netty4.io.netty.buffer.ByteBuf;
+import org.apache.flink.util.Preconditions;
/**
* Unique identifier for the attempt to execute a tasks. Multiple attempts happen
* in cases of failures and recovery.
*/
-public class ExecutionAttemptID extends AbstractID {
+public class ExecutionAttemptID implements java.io.Serializable {
private static final long serialVersionUID = -1169683445778281344L;
+ private final ExecutionVertexID executionVertexID;
Review comment:
NIT: `executionVertexId` would be better than `executionVertexID`.
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/strategy/ExecutionVertexID.java
##########
@@ -33,6 +35,10 @@
private final int subtaskIndex;
+ public ExecutionVertexID() {
Review comment:
Could we introduce a util method `ExecutionGraphTestUtils#createRandomExecutionVertexId()` to avoid pollute production code with test code? And make it true random with a random subtaskIndex as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on issue #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618208681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1a8bf3517bd92eb1af532182377cb9f4b57da6b8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KarmaGYZ commented on pull request #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on pull request #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-655406517
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on issue #11873: [FLINK-17295] Refactor the ExecutionAttemptID to consist of Execution…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11873:
URL: https://github.com/apache/flink/pull/11873#issuecomment-618208681
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
}, {
"hash" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161570750",
"triggerID" : "1a8bf3517bd92eb1af532182377cb9f4b57da6b8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1a8bf3517bd92eb1af532182377cb9f4b57da6b8 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161570750) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=106)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org