You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/10/28 14:12:24 UTC
[GitHub] [nifi-minifi-cpp] fgerlits opened a new pull request, #1444: MINIFICPP-1952 Reset the callback when no longer needed
fgerlits opened a new pull request, #1444:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1444
Without this, the callback would remain in the `HTTPClient` stored in the `ResourceQueue` in the `InvokeHTTP` processor, but the stream inside the callback would be pointing to a flow file resource claim which no longer exists.
This went mostly unnoticed, except in two of the test cases (`HTTPTestsResponseBodyinAttribute` and `HTTPTestsResponseBody`) in the MacOS CI job, which got stuck in the `InvokeHTTP` destructor. Thanks, AppleClang!
---
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1444: MINIFICPP-1952 Reset the callback when no longer needed
Posted by GitBox <gi...@apache.org>.
adamdebreceni commented on code in PR #1444:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1444#discussion_r1011698031
##########
extensions/http-curl/processors/InvokeHTTP.cpp:
##########
@@ -334,6 +334,10 @@ void InvokeHTTP::onTriggerWithClient(const std::shared_ptr<core::ProcessContext>
logger_->log_debug("onTrigger InvokeHTTP with %s to %s", client.getRequestMethod(), client.getURL());
+ const auto remove_callback_from_client_at_exit = gsl::finally([&client] {
+ client.setUploadCallback({});
Review Comment:
I feel like this is the responsibility of `ResourceQueue` and should be handled in `ResourceQueue::returnResource`, what I am thinking is a `resetter: std::function<void(ResourceType&)>` (probably an extra constructor argument to `ResourceQueue`) which when set would be called in `returnResource`, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1444: MINIFICPP-1952 Reset the callback when no longer needed
Posted by GitBox <gi...@apache.org>.
szaszm closed pull request #1444: MINIFICPP-1952 Reset the callback when no longer needed
URL: https://github.com/apache/nifi-minifi-cpp/pull/1444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1444: MINIFICPP-1952 Reset the callback when no longer needed
Posted by GitBox <gi...@apache.org>.
adamdebreceni commented on code in PR #1444:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1444#discussion_r1011744400
##########
extensions/http-curl/processors/InvokeHTTP.cpp:
##########
@@ -334,6 +334,10 @@ void InvokeHTTP::onTriggerWithClient(const std::shared_ptr<core::ProcessContext>
logger_->log_debug("onTrigger InvokeHTTP with %s to %s", client.getRequestMethod(), client.getURL());
+ const auto remove_callback_from_client_at_exit = gsl::finally([&client] {
+ client.setUploadCallback({});
Review Comment:
we can address this and any related issues with ResourceQueue in https://issues.apache.org/jira/browse/MINIFICPP-1973
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org