You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/07 00:22:22 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #13519: Update chart README with section on Airflow configuration

kaxil commented on a change in pull request #13519:
URL: https://github.com/apache/airflow/pull/13519#discussion_r553031467



##########
File path: chart/README.md
##########
@@ -32,6 +32,10 @@ cluster using the [Helm](https://helm.sh) package manager.
 - Helm 2.11+ or Helm 3.0+
 - PV provisioner support in the underlying infrastructure
 
+## Configuring Airflow
+
+All Airflow configuation parameters (equivalent of `airflow.cfg`) are stored in [values.yaml](https://github.com/apache/airflow/blob/master/chart/values.yaml). You may wish to consult these prior to Chart installation.
+

Review comment:
       The description is not clear enough, it also does not tell which key needs to be set, all configs need to go under `config` key:
   
   https://github.com/apache/airflow/blob/9c75ea3c14b71d2f96d997aeef68c764c7d2984c/chart/values.yaml#L643
   
   Would be better to give an example too




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org