You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/04/08 02:36:15 UTC

[GitHub] [pulsar] schahal opened a new pull request #6691: [Issue 6690] More accurately load the private key from PEM file

schahal opened a new pull request #6691: [Issue 6690] More accurately load the private key from PEM file
URL: https://github.com/apache/pulsar/pull/6691
 
 
   
   Fixes #6690 
   
   ### Motivation
   
   See #6690 - I'd received new certs, but because my pem file had attributes, pulsar proxy was unable to load the private key.
   
   ### Modifications
   
   How pulsar loads the private key from a PEM file
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   However, need assistance in verifying this, as I do not have many cycles to test/verify
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API: no
     - The schema: don't know
     - The default values of configurations: no
     - The wire protocol: no
     - The rest endpoints: no
     - The admin cli options: no
     - Anything that affects deployment: don't know
   
   ### Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
     - If a feature is not applicable for documentation, explain why? `bugfix`
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation - N/A
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] merlimat merged pull request #6691: [Issue 6690] More accurately load the private key from PEM file

Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #6691: [Issue 6690] More accurately load the private key from PEM file
URL: https://github.com/apache/pulsar/pull/6691
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services