You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "ferdnyc (via GitHub)" <gi...@apache.org> on 2023/07/13 04:12:01 UTC

[GitHub] [maven-build-cache-extension] ferdnyc commented on pull request #86: [MBUILDCACHE-60] Remove undeclared Guava dependency with Arrays.asList

ferdnyc commented on PR #86:
URL: https://github.com/apache/maven-build-cache-extension/pull/86#issuecomment-1633517427

   I'm with @elharo — I _hate_ merging my own code to a public repo, and will generally only do it if it's a non-code change or I can definitively state that merging won't impact other users.
   
   Otherwise, I figure a second pair of eyes is a sensible precaution on almost **any** code change, and when there are multiple people with commit access a good general rule is to have someone other than the PR author do the merge. I try to review others' changes as much as I can, in the hopes they'll return the favor.
   
   In that spirit, I've pitched in with an inexpert review of the changes here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org