[jira] [Commented] (MAPREDUCE-4851) add lifecycle to Comparators

["Harsh J (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511463#comment-13511463 ] 

Harsh J commented on MAPREDUCE-4851:
------------------------------------

I feel all your proposed "setup and cleanup" method addition work may as well go to a single JIRA cause they all almost border on making interface changes - and seem to have common motives (just spring again, or is there also a valid usecase to have a cleanup method behind a simple class such as a comparator?).
                
> add lifecycle to Comparators
> ----------------------------
>
>                 Key: MAPREDUCE-4851
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4851
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Radim Kolar
>              Labels: mrv2
>
> current mapreduce api is using RawComparator interface in:
> setGroupingComparatorClass
> setSortComparatorClass
> This interface has no lifecycle support. I propose to change that methods to take argument new class implements RawComparator with setup and cleanup methods. 
> This will leave existing code with RawComparator alone, Providing some backward compatibility.
> new class: 
> class SortComparator implements RawComparator

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira