You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2024/10/18 03:58:01 UTC
[PR] [SPARK-50011][INFRA][FOLLOW-UP] Refresh the image cache job [spark]
zhengruifeng opened a new pull request, #48533:
URL: https://github.com/apache/spark/pull/48533
### What changes were proposed in this pull request?
Refresh the image cache job
### Why are the changes needed?
this job has been broken: https://github.com/apache/spark/actions/runs/11387123331/job/31682246504
### Does this PR introduce _any_ user-facing change?
no, infra-only
### How was this patch tested?
ci
### Was this patch authored or co-authored using generative AI tooling?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50011][INFRA][FOLLOW-UP] Refresh the image cache job [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #48533:
URL: https://github.com/apache/spark/pull/48533#issuecomment-2422894033
Oh, it's too bad. It seems that the cache is gone and reverting makes the situation worse. :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50011][INFRA][FOLLOW-UP] Refresh the image cache job [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #48533:
URL: https://github.com/apache/spark/pull/48533#issuecomment-2423399352
oops, we discussed old branches before, but thought no change needed.
my bad, let me take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50011][INFRA][FOLLOW-UP] Refresh the image cache job [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #48533:
URL: https://github.com/apache/spark/pull/48533#issuecomment-2421518427
thank you @Yikun @dongjoon-hyun and @HyukjinKwon
merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50011][INFRA][FOLLOW-UP] Refresh the image cache job [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #48533:
URL: https://github.com/apache/spark/pull/48533#issuecomment-2422885092
Sorry, but let me revert this first for now in order to recover the release branch CIs as a release manager for Apache Spark 3.4.4 EOL release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50011][INFRA][FOLLOW-UP] Refresh the image cache job [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #48533:
URL: https://github.com/apache/spark/pull/48533#discussion_r1805835425
##########
.github/workflows/build_infra_images_cache.yml:
##########
@@ -26,7 +26,8 @@ on:
- 'master'
- 'branch-*'
paths:
- - 'dev/infra/Dockerfile'
+ - 'dev/infra/base/Dockerfile'
+ - 'dev/infra/docs/Dockerfile'
Review Comment:
Oh, right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50011][INFRA][FOLLOW-UP] Refresh the image cache job [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #48533:
URL: https://github.com/apache/spark/pull/48533#issuecomment-2422878623
To @zhengruifeng , unfortunately, it seems that this broke branch-3.5 and branch-3.4. Could you take a look at that?
```
Error: buildx failed with: ERROR: unable to prepare context: path "./dev/infra/base/" not found
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50011][INFRA][FOLLOW-UP] Refresh the image cache job [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #48533:
URL: https://github.com/apache/spark/pull/48533#issuecomment-2422887362
This is reverted via https://github.com/apache/spark/commit/aaecab3d3c8b116e4aa32b2b26ad6a1b32f2a80a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50011][INFRA][FOLLOW-UP] Refresh the image cache job [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #48533:
URL: https://github.com/apache/spark/pull/48533#issuecomment-2423400564
No problem at all. As you know, I inevitably reverted them to unblock Apache Spark 3.4.4 release preparation (next Monday). If we don't have a release schedule, they would remain in the branch.
Thank you again, @zhengruifeng !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50011][INFRA][FOLLOW-UP] Refresh the image cache job [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #48533: [SPARK-50011][INFRA][FOLLOW-UP] Refresh the image cache job
URL: https://github.com/apache/spark/pull/48533
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50011][INFRA][FOLLOW-UP] Refresh the image cache job [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #48533:
URL: https://github.com/apache/spark/pull/48533#issuecomment-2421961154
Thank all, it seems this the cache take effect in both master https://github.com/apache/spark/actions/runs/11399304381/job/31717882423 and my repo https://github.com/zhengruifeng/spark/actions/runs/11399270535/job/31717789932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50011][INFRA][FOLLOW-UP] Refresh the image cache job [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #48533:
URL: https://github.com/apache/spark/pull/48533#issuecomment-2422900418
Let me revert SPARK0-50011 too because it never works seamlessly until now in all CI combinations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org