[GitHub] [skywalking-python] jiang1997 commented on a diff in pull request #231: feat: Add support for MeterReportService

["jiang1997 (via GitHub)" <gi...@apache.org>]

jiang1997 commented on code in PR #231:
URL: https://github.com/apache/skywalking-python/pull/231#discussion_r1124865157


##########
skywalking/client/__init__.py:
##########
@@ -28,6 +28,9 @@ class TraceSegmentReportService(object):
     def report(self, generator):
         raise NotImplementedError()
 
+class MeterReportService(object):
+    def report(self, generator):

Review Comment:
   @March225
   This is just a simple supplement to wu-sheng's advice for the sake of simplicity.
   1. Try to append your metric's definition to the server-side [config](https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/meter-analyzer-config/python-runtime.yaml#L31-L36) file like below
   https://github.com/apache/skywalking/blob/e2f1c0eadb52082e16f3abfc29dd8860000b596b/oap-server/server-starter/src/main/resources/meter-analyzer-config/python-runtime.yaml#L31-L36
   Then edit the dashboard and add new widget to show your metric.
   2. If nothing goes wrong, you should find your metric here.
   ![image](https://user-images.githubusercontent.com/28537230/222797852-9a942c0e-2a5f-4e47-88de-0650c48dd2be.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org