You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2014/04/17 02:45:14 UTC
Review Request 20439: Flume: service and component status should be
calculated correctly
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20439/
-----------------------------------------------------------
Review request for Ambari, Dmytro Sen, Myroslav Papirkovskyy, and Sid Wagle.
Bugs: AMBARI-5488
https://issues.apache.org/jira/browse/AMBARI-5488
Repository: ambari
Description
-------
* Added special Flume ServiceState instance because the rules are different there
* Raise an error on the flume.py script when Flume instances are not running
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 1931121
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py 9ac23d9
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_handler.py f796435
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java ee8e1ba
ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 7a2ba8b
Diff: https://reviews.apache.org/r/20439/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 14:07.713s
[INFO] Finished at: Wed Apr 16 20:40:37 EDT 2014
[INFO] Final Memory: 20M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 20439: Flume: service and component status should be
calculated correctly
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20439/#review40652
-----------------------------------------------------------
Ship it!
Ship It!
- Dmytro Sen
On April 17, 2014, 2:26 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20439/
> -----------------------------------------------------------
>
> (Updated April 17, 2014, 2:26 p.m.)
>
>
> Review request for Ambari, Dmytro Sen, Myroslav Papirkovskyy, and Sid Wagle.
>
>
> Bugs: AMBARI-5488
> https://issues.apache.org/jira/browse/AMBARI-5488
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Added special Flume ServiceState instance because the rules are different there
> * Raise an error on the flume.py script when Flume instances are not running
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 1931121
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py 9ac23d9
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_handler.py f796435
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java ee8e1ba
> ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 7a2ba8b
>
> Diff: https://reviews.apache.org/r/20439/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 14:07.713s
> [INFO] Finished at: Wed Apr 16 20:40:37 EDT 2014
> [INFO] Final Memory: 20M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 20439: Flume: service and component status should be
calculated correctly
Posted by Nate Cole <nc...@hortonworks.com>.
> On April 17, 2014, 11:06 a.m., Dmytro Sen wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java, line 1147
> > <https://reviews.apache.org/r/20439/diff/2/?file=561591#file561591line1147>
> >
> > too much spaces ))
Thanks, I have another patch soon and I'll address this.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20439/#review40651
-----------------------------------------------------------
On April 17, 2014, 10:26 a.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20439/
> -----------------------------------------------------------
>
> (Updated April 17, 2014, 10:26 a.m.)
>
>
> Review request for Ambari, Dmytro Sen, Myroslav Papirkovskyy, and Sid Wagle.
>
>
> Bugs: AMBARI-5488
> https://issues.apache.org/jira/browse/AMBARI-5488
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Added special Flume ServiceState instance because the rules are different there
> * Raise an error on the flume.py script when Flume instances are not running
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 1931121
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py 9ac23d9
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_handler.py f796435
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java ee8e1ba
> ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 7a2ba8b
>
> Diff: https://reviews.apache.org/r/20439/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 14:07.713s
> [INFO] Finished at: Wed Apr 16 20:40:37 EDT 2014
> [INFO] Final Memory: 20M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 20439: Flume: service and component status should be
calculated correctly
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20439/#review40651
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
<https://reviews.apache.org/r/20439/#comment73717>
too much spaces ))
- Dmytro Sen
On April 17, 2014, 2:26 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20439/
> -----------------------------------------------------------
>
> (Updated April 17, 2014, 2:26 p.m.)
>
>
> Review request for Ambari, Dmytro Sen, Myroslav Papirkovskyy, and Sid Wagle.
>
>
> Bugs: AMBARI-5488
> https://issues.apache.org/jira/browse/AMBARI-5488
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Added special Flume ServiceState instance because the rules are different there
> * Raise an error on the flume.py script when Flume instances are not running
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 1931121
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py 9ac23d9
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_handler.py f796435
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java ee8e1ba
> ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 7a2ba8b
>
> Diff: https://reviews.apache.org/r/20439/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 14:07.713s
> [INFO] Finished at: Wed Apr 16 20:40:37 EDT 2014
> [INFO] Final Memory: 20M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 20439: Flume: service and component status should be
calculated correctly
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20439/
-----------------------------------------------------------
(Updated April 17, 2014, 10:26 a.m.)
Review request for Ambari, Dmytro Sen, Myroslav Papirkovskyy, and Sid Wagle.
Changes
-------
Update for missed logic (missed commit before making patch)
Bugs: AMBARI-5488
https://issues.apache.org/jira/browse/AMBARI-5488
Repository: ambari
Description
-------
* Added special Flume ServiceState instance because the rules are different there
* Raise an error on the flume.py script when Flume instances are not running
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java 1931121
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py 9ac23d9
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_handler.py f796435
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ServiceResourceProviderTest.java ee8e1ba
ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 7a2ba8b
Diff: https://reviews.apache.org/r/20439/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 14:07.713s
[INFO] Finished at: Wed Apr 16 20:40:37 EDT 2014
[INFO] Final Memory: 20M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole