You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/06/04 18:27:11 UTC
[GitHub] [storm] govind-menon opened a new pull request #3281: Adds OFF HEAP to worker child opts
govind-menon opened a new pull request #3281:
URL: https://github.com/apache/storm/pull/3281
## What is the purpose of the change
*(Explain why we should have this change)*
## How was the change tested
*(Explain what tests did you do to verify the code change)*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] Ethanlm merged pull request #3281: STORM-3647: Adds OFF HEAP to worker child opts
Posted by GitBox <gi...@apache.org>.
Ethanlm merged pull request #3281:
URL: https://github.com/apache/storm/pull/3281
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] govind-menon commented on pull request #3281: STORM-3647: Adds OFF HEAP to worker child opts
Posted by GitBox <gi...@apache.org>.
govind-menon commented on pull request #3281:
URL: https://github.com/apache/storm/pull/3281#issuecomment-639120389
Yes that is correct
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] Ethanlm commented on pull request #3281: STORM-3647: Adds OFF HEAP to worker child opts
Posted by GitBox <gi...@apache.org>.
Ethanlm commented on pull request #3281:
URL: https://github.com/apache/storm/pull/3281#issuecomment-639090241
please update commit message to also include the jira id
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] govind-menon commented on pull request #3281: STORM-3647: Adds OFF HEAP to worker child opts
Posted by GitBox <gi...@apache.org>.
govind-menon commented on pull request #3281:
URL: https://github.com/apache/storm/pull/3281#issuecomment-639112741
The off heap memory requested for the executor is what is put in the flag
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] Ethanlm commented on pull request #3281: STORM-3647: Adds OFF HEAP to worker child opts
Posted by GitBox <gi...@apache.org>.
Ethanlm commented on pull request #3281:
URL: https://github.com/apache/storm/pull/3281#issuecomment-639118251
Yes but if worker.childopts doesn't have `%OFF-HEAP-MEM%`, this setting is not really enforced, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] govind-menon commented on pull request #3281: STORM-3647: Adds OFF HEAP to worker child opts
Posted by GitBox <gi...@apache.org>.
govind-menon commented on pull request #3281:
URL: https://github.com/apache/storm/pull/3281#issuecomment-639103137
@Ethanlm Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] Ethanlm commented on pull request #3281: STORM-3647: Adds OFF HEAP to worker child opts
Posted by GitBox <gi...@apache.org>.
Ethanlm commented on pull request #3281:
URL: https://github.com/apache/storm/pull/3281#issuecomment-639111921
How can a topology use off heap memory? Setting %OFF-HEAP-MEM% doesn't seem enough?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [storm] Ethanlm edited a comment on pull request #3281: STORM-3647: Adds OFF HEAP to worker child opts
Posted by GitBox <gi...@apache.org>.
Ethanlm edited a comment on pull request #3281:
URL: https://github.com/apache/storm/pull/3281#issuecomment-639111921
How can a topology use off heap memory? %OFF-HEAP-MEM% is not really used in the template `worker.childopts`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org