[GitHub] [griffin] wankunde commented on issue #560: [GRIFFIN-312] Code Style Standardization

[GitBox <gi...@apache.org>]

wankunde commented on issue #560: [GRIFFIN-312] Code Style Standardization
URL: https://github.com/apache/griffin/pull/560#issuecomment-568336509
 
 
   @chitralverma 
   
   The plugin name should change with the scala version,  and it has some compatibility problems with  scala 2.13.
   
   Could you update your code?
   
   https://issues.apache.org/jira/browse/SPARK-29293
   
   https://github.com/apache/spark/blob/e5abbab0ed5d9d70522c1e19c53e95c631dd1565/pom.xml#L3026
   
   scala-2.11 version:
   ```xml
   <plugin>
                   <groupId>org.antipathy</groupId>
                   <artifactId>mvn-scalafmt_2.11</artifactId>
                   <version>0.12_1.5.1</version>
                   <configuration>
                       <parameters>${scalafmt.parameters}</parameters>
                       <skip>${scalafmt.skip}</skip>
                       <skipSources>${scalafmt.skip}</skipSources>
                       <skipTestSources>${scalafmt.skip}</skipTestSources>
                       <configLocation>${project.parent.basedir}/.scalafmt.conf</configLocation>
                   </configuration>
                   <executions>
                       <execution>
                           <phase>validate</phase>
                           <goals>
                               <goal>format</goal>
                           </goals>
                       </execution>
                   </executions>
               </plugin>
   ```
   scala-2.12 version:
   ```xml
       <profile>
         <id>scala-2.12</id>
         <build>
           <pluginManagement>
             <plugins>
               <!-- SPARK-29293 currently not able to update to 1.x for Scala 2.13 -->
               <plugin>
                 <groupId>org.antipathy</groupId>
                 <artifactId>mvn-scalafmt_2.12</artifactId>
                 <version>0.12_1.5.1</version>
                 <configuration>
                   <parameters>${scalafmt.parameters}</parameters> <!-- (Optional) Additional command line arguments -->
                   <skip>${scalafmt.skip}</skip> <!-- (Optional) skip formatting -->
                   <skipSources>${scalafmt.skip}</skipSources>
                   <skipTestSources>${scalafmt.skip}</skipTestSources>
                   <configLocation>dev/.scalafmt.conf</configLocation> <!-- (Optional) config location -->
                 </configuration>
                 <executions>
                   <execution>
                     <phase>validate</phase>
                     <goals>
                       <goal>format</goal>
                     </goals>
                   </execution>
                 </executions>
               </plugin>
             </plugins>
           </pluginManagement>
         </build>
       </profile>
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services