You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/12/22 07:26:16 UTC
[GitHub] [servicecomb-java-chassis] codecov-io commented on pull request #2157: [SCB-2169] optimize filter declare and chain config
codecov-io commented on pull request #2157:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2157#issuecomment-749391766
# [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2157?src=pr&el=h1) Report
> Merging [#2157](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2157?src=pr&el=desc) (984ffd9) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/323d5b7c406583867eacaa758b28e0fdcfcbe2c6?el=desc) (323d5b7) will **decrease** coverage by `0.01%`.
> The diff coverage is `64.39%`.
[](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2157?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2157 +/- ##
============================================
- Coverage 80.76% 80.74% -0.02%
Complexity 1339 1339
============================================
Files 1463 1462 -1
Lines 40142 40144 +2
Branches 3411 3412 +1
============================================
- Hits 32420 32414 -6
- Misses 6255 6265 +10
+ Partials 1467 1465 -2
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2157?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...org/apache/servicecomb/core/filter/FilterNode.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2157/diff?src=pr&el=tree#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9maWx0ZXIvRmlsdGVyTm9kZS5qYXZh) | `87.09% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...comb/core/filter/impl/SimpleLoadBalanceFilter.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2157/diff?src=pr&el=tree#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9maWx0ZXIvaW1wbC9TaW1wbGVMb2FkQmFsYW5jZUZpbHRlci5qYXZh) | `11.90% <7.89%> (-13.81%)` | `0.00 <0.00> (ø)` | |
| [...ava/org/apache/servicecomb/core/filter/Filter.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2157/diff?src=pr&el=tree#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9maWx0ZXIvRmlsdGVyLmphdmE=) | `50.00% <33.33%> (-16.67%)` | `0.00 <0.00> (ø)` | |
| [...icecomb/transport/highway/HighwayClientFilter.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2157/diff?src=pr&el=tree#diff-dHJhbnNwb3J0cy90cmFuc3BvcnQtaGlnaHdheS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvdHJhbnNwb3J0L2hpZ2h3YXkvSGlnaHdheUNsaWVudEZpbHRlci5qYXZh) | `9.09% <33.33%> (+2.19%)` | `0.00 <0.00> (ø)` | |
| [...e/servicecomb/core/filter/FilterChainsManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2157/diff?src=pr&el=tree#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9maWx0ZXIvRmlsdGVyQ2hhaW5zTWFuYWdlci5qYXZh) | `48.64% <53.57%> (-2.52%)` | `0.00 <0.00> (ø)` | |
| [...ache/servicecomb/core/filter/impl/EmptyFilter.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2157/diff?src=pr&el=tree#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9maWx0ZXIvaW1wbC9FbXB0eUZpbHRlci5qYXZh) | `66.66% <66.66%> (ø)` | `0.00 <0.00> (?)` | |
| [...ervicecomb/core/filter/InvocationFilterChains.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2157/diff?src=pr&el=tree#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9maWx0ZXIvSW52b2NhdGlvbkZpbHRlckNoYWlucy5qYXZh) | `70.27% <70.27%> (ø)` | `0.00 <0.00> (?)` | |
| [...re/filter/config/InvocationFilterChainsConfig.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2157/diff?src=pr&el=tree#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9maWx0ZXIvY29uZmlnL0ludm9jYXRpb25GaWx0ZXJDaGFpbnNDb25maWcuamF2YQ==) | `77.77% <77.77%> (ø)` | `0.00 <0.00> (?)` | |
| [...comb/core/filter/config/TransportChainsConfig.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2157/diff?src=pr&el=tree#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9maWx0ZXIvY29uZmlnL1RyYW5zcG9ydENoYWluc0NvbmZpZy5qYXZh) | `83.33% <80.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...vicecomb/demo/pojo/client/CodeFirstPojoClient.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2157/diff?src=pr&el=tree#diff-ZGVtby9kZW1vLXBvam8vcG9qby1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RlbW8vcG9qby9jbGllbnQvQ29kZUZpcnN0UG9qb0NsaWVudC5qYXZh) | `97.43% <88.88%> (ø)` | `23.00 <2.00> (ø)` | |
| ... and [19 more](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2157/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2157?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2157?src=pr&el=footer). Last update [323d5b7...984ffd9](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2157?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org