You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/10/19 20:45:18 UTC
[GitHub] [iceberg] aokolnychyi opened a new pull request #3321: Spark: Remove redundant abstract test classes
aokolnychyi opened a new pull request #3321:
URL: https://github.com/apache/iceberg/pull/3321
This PR removes redundant abstract test classes in Spark after we moved the common code into subfolders.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi removed a comment on pull request #3321: Spark: Remove redundant abstract test classes
Posted by GitBox <gi...@apache.org>.
aokolnychyi removed a comment on pull request #3321:
URL: https://github.com/apache/iceberg/pull/3321#issuecomment-947142472
Then I assume that change was intentional and we simply need to remove that abstract test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #3321: Spark: Remove redundant abstract test classes
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #3321:
URL: https://github.com/apache/iceberg/pull/3321#issuecomment-947144074
Thanks for checking, @RussellSpitzer!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #3321: Spark: Remove redundant abstract test classes
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #3321:
URL: https://github.com/apache/iceberg/pull/3321#issuecomment-947127418
Weird, the test failures are happening because I enabled test that was disabled for a while.
It looks the suite was ignored by accident in [this](https://github.com/apache/iceberg/commit/2f136e9da5630e1f4f402f847b1d9e6a40c7401a#diff-534ed65325ae5f7f180b4dbe6c[…]c8be0bfd681ccfb8a5243e8f93f70b7d) commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #3321: Spark: Remove redundant abstract test classes
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #3321:
URL: https://github.com/apache/iceberg/pull/3321#issuecomment-947173357
Yeah, we don't support the schema argument in Spark 3 so the test isn't needed. Thanks for fixing this, @aokolnychyi! I merged it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on pull request #3321: Spark: Remove redundant abstract test classes
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on pull request #3321:
URL: https://github.com/apache/iceberg/pull/3321#issuecomment-947140885
As far as I can tell, our implementation of IcebergSource in Spark3 ignores Schema args all together,
https://github.com/apache/iceberg/blob/3f4c9c99c82fc45fc77b97acc7a160be88b5cc20/spark/v3.0/spark3/src/main/java/org/apache/iceberg/spark/source/IcebergSource.java#L80-L93
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] RussellSpitzer commented on pull request #3321: Spark: Remove redundant abstract test classes
Posted by GitBox <gi...@apache.org>.
RussellSpitzer commented on pull request #3321:
URL: https://github.com/apache/iceberg/pull/3321#issuecomment-947142600
Looks like we removed that capability in the commit in question
https://github.com/apache/iceberg/commit/2f136e9da5630e1f4f402f847b1d9e6a40c7401a#diff-6137fecd2e0b341d7302673c2b286005f5ef1e30f7bf3ee16899b04402ca22d5L58-R96
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #3321: Spark: Remove redundant abstract test classes
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #3321:
URL: https://github.com/apache/iceberg/pull/3321#issuecomment-947142058
Then I assume that change was intentional and we simply need to remove that abstract test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #3321: Spark: Remove redundant abstract test classes
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #3321:
URL: https://github.com/apache/iceberg/pull/3321#issuecomment-947142472
Then I assume that change was intentional and we simply need to remove that abstract test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #3321: Spark: Remove redundant abstract test classes
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #3321:
URL: https://github.com/apache/iceberg/pull/3321#issuecomment-947190053
Thanks for reviewing, @rdblue @RussellSpitzer!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #3321: Spark: Remove redundant abstract test classes
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #3321:
URL: https://github.com/apache/iceberg/pull/3321#issuecomment-947129529
I'll revert enabling this test to unblock this PR but I wonder whether the original ignore was intentional.
@rymurr @rdblue @RussellSpitzer, any context?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #3321: Spark: Remove redundant abstract test classes
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #3321:
URL: https://github.com/apache/iceberg/pull/3321
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org