You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/01/09 23:30:05 UTC

[GitHub] [hudi] satishkotha commented on a change in pull request #2422: [HUDI-1276] [HUDI-1459] Make Clustering/ReplaceCommit and Metadata table be compatible

satishkotha commented on a change in pull request #2422:
URL: https://github.com/apache/hudi/pull/2422#discussion_r554485792



##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/RollbackUtils.java
##########
@@ -122,6 +122,7 @@ static HoodieRollbackStat mergeRollbackStat(HoodieRollbackStat stat1, HoodieRoll
       List<ListingBasedRollbackRequest> partitionRollbackRequests = new ArrayList<>();
       switch (instantToRollback.getAction()) {
         case HoodieTimeline.COMMIT_ACTION:
+        case HoodieTimeline.REPLACE_COMMIT_ACTION:

Review comment:
       Yes, this was missed because MOR is not well tested with clustering/insert_overwrite. New test covers this. Btw, There may be other places where we might be missing similar handling of REPLACE_COMMIT. I tried doing an audit, but its very tedious. So, I may have missed some places. Let me know if you find any.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org