You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nikhil P <ni...@gmail.com> on 2018/05/04 10:26:21 UTC

Review Request 66946: Good coding practice for ranger response codes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66946/
-----------------------------------------------------------

Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-2091
    https://issues.apache.org/jira/browse/RANGER-2091


Repository: ranger


Description
-------

Good coding practice for ranger response codes


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthenticationEntryPoint.java de3891e 


Diff: https://reviews.apache.org/r/66946/diff/1/


Testing
-------

1)Tested on simple as well as kerberised environment.
2)Tested with Knox SSO,Knox Proxy, wire encryption.


Thanks,

Nikhil P


Re: Review Request 66946: Good coding practice for ranger response codes

Posted by Zsombor Gegesy <zs...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66946/#review202434
-----------------------------------------------------------


Ship it!




Ship It!

- Zsombor Gegesy


On May 4, 2018, 10:26 a.m., Nikhil P wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66946/
> -----------------------------------------------------------
> 
> (Updated May 4, 2018, 10:26 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2091
>     https://issues.apache.org/jira/browse/RANGER-2091
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Good coding practice for ranger response codes
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthenticationEntryPoint.java de3891e 
> 
> 
> Diff: https://reviews.apache.org/r/66946/diff/1/
> 
> 
> Testing
> -------
> 
> 1)Tested on simple as well as kerberised environment.
> 2)Tested with Knox SSO,Knox Proxy, wire encryption.
> 
> 
> Thanks,
> 
> Nikhil P
> 
>


Re: Review Request 66946: Good coding practice for ranger response codes

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66946/#review202441
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On May 4, 2018, 10:26 a.m., Nikhil P wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66946/
> -----------------------------------------------------------
> 
> (Updated May 4, 2018, 10:26 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2091
>     https://issues.apache.org/jira/browse/RANGER-2091
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Good coding practice for ranger response codes
> 
> 
> Diffs
> -----
> 
>   security-admin/src/main/java/org/apache/ranger/security/web/authentication/RangerAuthenticationEntryPoint.java de3891e 
> 
> 
> Diff: https://reviews.apache.org/r/66946/diff/1/
> 
> 
> Testing
> -------
> 
> 1)Tested on simple as well as kerberised environment.
> 2)Tested with Knox SSO,Knox Proxy, wire encryption.
> 
> 
> Thanks,
> 
> Nikhil P
> 
>