You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ah...@apache.org on 2020/03/06 19:27:11 UTC

[royale-asjs] branch develop updated: remove unused import

This is an automated email from the ASF dual-hosted git repository.

aharui pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new 3d54dd5  remove unused import
3d54dd5 is described below

commit 3d54dd5e43a922270dc0eb2c205bbb4ac674d840
Author: Alex Harui <ah...@apache.org>
AuthorDate: Fri Mar 6 11:26:48 2020 -0800

    remove unused import
---
 .../src/test/royale/flexUnitTests/binding/utils/BindableTestUtil.as      | 1 -
 1 file changed, 1 deletion(-)

diff --git a/frameworks/projects/Binding/src/test/royale/flexUnitTests/binding/utils/BindableTestUtil.as b/frameworks/projects/Binding/src/test/royale/flexUnitTests/binding/utils/BindableTestUtil.as
index 5d2abcb..5762b74 100644
--- a/frameworks/projects/Binding/src/test/royale/flexUnitTests/binding/utils/BindableTestUtil.as
+++ b/frameworks/projects/Binding/src/test/royale/flexUnitTests/binding/utils/BindableTestUtil.as
@@ -17,7 +17,6 @@
 //
 ////////////////////////////////////////////////////////////////////////////////
 package flexUnitTests.binding.utils {
-import testshim.RoyaleUnitTestRunner;
 
 
 COMPILE::Flex{


Re: [royale-asjs] branch develop updated: remove unused import

Posted by Greg Dove <gr...@gmail.com>.
Thanks - I missed another one. I was trying to keep test code aligned
across 3 different projects while I was getting it to work for Flex and
Royale, and ultimately into the Binding framework build tests. That was a
bit complicated, but it should be much easier going forward. After moving
around the directories a bit, I also messed up a bit with git and had to
take a couple of shots at fixing that, but I obviously missed that import.

I do have a working FlexUnitUI setup for these if you (or anyone else)
wants that. I fIgured it did not make sense to check it into Royale
itself...
This way for any binding bugs, if they can be set up as an (obviously
passing) test in Flex, then a comparative test can be easily set up for
Royale. At least that is the theory (so far it works).
I will do this for itemrenderer testing soon. It's not about changing the
implementation (Royale is different, with more specific/efficient  binding
support as it should be), it's just about ensuring the same results.



On Sat, Mar 7, 2020 at 8:27 AM <ah...@apache.org> wrote:

> This is an automated email from the ASF dual-hosted git repository.
>
> aharui pushed a commit to branch develop
> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>
>
> The following commit(s) were added to refs/heads/develop by this push:
>      new 3d54dd5  remove unused import
> 3d54dd5 is described below
>
> commit 3d54dd5e43a922270dc0eb2c205bbb4ac674d840
> Author: Alex Harui <ah...@apache.org>
> AuthorDate: Fri Mar 6 11:26:48 2020 -0800
>
>     remove unused import
> ---
>  .../src/test/royale/flexUnitTests/binding/utils/BindableTestUtil.as
> | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git
> a/frameworks/projects/Binding/src/test/royale/flexUnitTests/binding/utils/BindableTestUtil.as
> b/frameworks/projects/Binding/src/test/royale/flexUnitTests/binding/utils/BindableTestUtil.as
> index 5d2abcb..5762b74 100644
> ---
> a/frameworks/projects/Binding/src/test/royale/flexUnitTests/binding/utils/BindableTestUtil.as
> +++
> b/frameworks/projects/Binding/src/test/royale/flexUnitTests/binding/utils/BindableTestUtil.as
> @@ -17,7 +17,6 @@
>  //
>
>  ////////////////////////////////////////////////////////////////////////////////
>  package flexUnitTests.binding.utils {
> -import testshim.RoyaleUnitTestRunner;
>
>
>  COMPILE::Flex{
>
>