[GitHub] [hadoop] elek commented on issue #1256: HDDS-1937. Acceptance tests fail if scm webui shows invalid json

[GitBox <gi...@apache.org>]

elek commented on issue #1256: HDDS-1937. Acceptance tests fail if scm webui shows invalid json
URL: https://github.com/apache/hadoop/pull/1256#issuecomment-523391840
 
 
   > I think it's simpler to add `|| true` after `jq`:
   > 
   > ```shell
   >   fi \
   >     | jq -r '.beans[0].NodeCount[] | select(.key=="HEALTHY") | .value' \
   >     || true
   > ```
   
   Yes, it's also possible. But my feeling is that `set -e` on the top level is dangerous and can be better remove it.
   
    1. It's hard to follow the sections where set -e/+e are enabled. With the new approach they set in the scope of the selected methods. I think it's easier to understand that which methods can fail
    
    2. It's hard to debug the script locally with `source testlib.sh` and execute the command because most of the time the shell can be exited and hard to follow why... 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org