[GitHub] flink pull request #4169: [FLINK-6357] [java] ParameterTool get unrequested ...

[NicoK <gi...@git.apache.org>]

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4169#discussion_r125911549
  
    --- Diff: flink-java/src/test/java/org/apache/flink/api/java/utils/ParameterToolTest.java ---
    @@ -154,4 +149,149 @@ public void testFromGenericOptionsParser() throws IOException {
     		ParameterTool parameter = ParameterTool.fromGenericOptionsParser(new String[]{"-D", "input=myInput", "-DexpectedCount=15"});
     		validate(parameter);
     	}
    +
    +	@Test
    +	public void testUnrequestedBoolean() {
    +		ParameterTool parameter = ParameterTool.fromArgs(new String[]{"-boolean", "true"});
    +		Assert.assertEquals(Sets.newHashSet("boolean"), parameter.getUnrequestedParameters());
    +
    +		// test parameter access
    +		Assert.assertTrue(parameter.getBoolean("boolean"));
    +		Assert.assertEquals(Collections.emptySet(), parameter.getUnrequestedParameters());
    +
    +		// test repeated access
    +		Assert.assertTrue(parameter.getBoolean("boolean"));
    +	}
    +
    +	@Test
    +	public void testUnrequestedByte() {
    +		ParameterTool parameter = ParameterTool.fromArgs(new String[]{"-byte", "1"});
    +		Assert.assertEquals(Sets.newHashSet("byte"), parameter.getUnrequestedParameters());
    +
    +		// test parameter access
    +		Assert.assertEquals(1, parameter.getByte("byte"));
    +		Assert.assertEquals(Collections.emptySet(), parameter.getUnrequestedParameters());
    +
    +		// test repeated access
    +		Assert.assertEquals(1, parameter.getByte("byte"));
    +	}
    +
    +	@Test
    +	public void testUnrequestedShort() {
    +		ParameterTool parameter = ParameterTool.fromArgs(new String[]{"-short", "2"});
    +		Assert.assertEquals(Sets.newHashSet("short"), parameter.getUnrequestedParameters());
    +
    +		// test parameter access
    +		Assert.assertEquals(2, parameter.getShort("short"));
    +		Assert.assertEquals(Collections.emptySet(), parameter.getUnrequestedParameters());
    +
    +		// test repeated access
    +		Assert.assertEquals(2, parameter.getShort("short"));
    --- End diff --
    
    same here: add the check?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---