You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2017/09/04 12:14:55 UTC
Review Request 62061: Revert "Removed core file during distclean.".
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62061/
-----------------------------------------------------------
Review request for mesos, Kapil Arya and Vinod Kone.
Bugs: MESOS-7722
https://issues.apache.org/jira/browse/MESOS-7722
Repository: mesos
Description
-------
This reverts commit fcf8618be59ada6d1607696b13bc362bf7e85b0b.
As we have fixed coredumps caused by passing an invalid path to
executable to `subprocess` (see https://reviews.apache.org/r/61799),
invocation of `perf` command, which isn't installed,
won't cause coredumps.
Diffs
-----
src/Makefile.am a4f2ee008eba263fe52c4e58c305e3fb9ba42f6b
Diff: https://reviews.apache.org/r/62061/diff/1/
Testing
-------
make check
apache CI
Thanks,
Andrei Budnik
Re: Review Request 62061: Revert "Removed core file during
distclean.".
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62061/#review184491
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61797, 61798, 61799, 61800, 61801, 62061]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Sept. 4, 2017, 12:14 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62061/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2017, 12:14 p.m.)
>
>
> Review request for mesos, Kapil Arya and Vinod Kone.
>
>
> Bugs: MESOS-7722
> https://issues.apache.org/jira/browse/MESOS-7722
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This reverts commit fcf8618be59ada6d1607696b13bc362bf7e85b0b.
>
> As we have fixed coredumps caused by passing an invalid path to
> executable to `subprocess` (see https://reviews.apache.org/r/61799),
> invocation of `perf` command, which isn't installed,
> won't cause coredumps.
>
>
> Diffs
> -----
>
> src/Makefile.am a4f2ee008eba263fe52c4e58c305e3fb9ba42f6b
>
>
> Diff: https://reviews.apache.org/r/62061/diff/1/
>
>
> Testing
> -------
>
> make check
> apache CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 62061: Revert "Removed core file during
distclean.".
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62061/#review184550
-----------------------------------------------------------
FAIL: 'Mesos testes failed to run'
Reviews applied: [61797, 61798, 61799, 61800, 61801, 62061]
Logs available here: 'http://mesos-logs.westus.cloudapp.azure.com/mesos-build/review/61211/logs'
- Mesos Reviewbot Windows
On Sept. 4, 2017, 12:14 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62061/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2017, 12:14 p.m.)
>
>
> Review request for mesos, Kapil Arya and Vinod Kone.
>
>
> Bugs: MESOS-7722
> https://issues.apache.org/jira/browse/MESOS-7722
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This reverts commit fcf8618be59ada6d1607696b13bc362bf7e85b0b.
>
> As we have fixed coredumps caused by passing an invalid path to
> executable to `subprocess` (see https://reviews.apache.org/r/61799),
> invocation of `perf` command, which isn't installed,
> won't cause coredumps.
>
>
> Diffs
> -----
>
> src/Makefile.am a4f2ee008eba263fe52c4e58c305e3fb9ba42f6b
>
>
> Diff: https://reviews.apache.org/r/62061/diff/1/
>
>
> Testing
> -------
>
> make check
> apache CI
>
>
> Thanks,
>
> Andrei Budnik
>
>