You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "dstandish (via GitHub)" <gi...@apache.org> on 2026/01/26 18:38:14 UTC
[I] Don't use isinstance for latest runs statement in dag processing [airflow]
dstandish opened a new issue, #61086:
URL: https://github.com/apache/airflow/issues/61086
### Body
in `_RunInfo.calculate`, we use isinstance cron partition timetable to figure out how to calculate latest run
this is not ideal. find a better solution. maybe add an attribtue to the timetable, or to the model, or come up with something else.
### Committer
- [x] I acknowledge that I am a maintainer/committer of the Apache Airflow project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Don't use isinstance for latest runs statement in dag processing [airflow]
Posted by "sanchalitorpe-source (via GitHub)" <gi...@apache.org>.
sanchalitorpe-source commented on issue #61086:
URL: https://github.com/apache/airflow/issues/61086#issuecomment-3806290720
I took a look at _RunInfo.calculate and see how the logic currently branches based on timetable type.
Would the intended direction be for timetables themselves to expose something like a “latest run calculation strategy” (e.g. via a method or attribute), so _RunInfo doesn’t need to know about concrete timetable classes?
I’m trying to understand whether this responsibility should live on the timetable side vs the DAG/model side before digging deeper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Don't use isinstance for latest runs statement in dag processing [airflow]
Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on issue #61086:
URL: https://github.com/apache/airflow/issues/61086#issuecomment-3821688281
Hey, thank you for looking into it. It's actually part of https://github.com/apache/airflow/pull/59115 and not yet part of airflow. @dstandish and I discussed a bit offline, and I'll take care of this one since we've been discussing the details of it. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Don't use isinstance for latest runs statement in dag processing [airflow]
Posted by "sanchalitorpe-source (via GitHub)" <gi...@apache.org>.
sanchalitorpe-source commented on issue #61086:
URL: https://github.com/apache/airflow/issues/61086#issuecomment-3821713428
Thanks for the clarification! Makes sense that this is tied to #59115. Appreciate the context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Don't use isinstance for latest runs statement in dag processing [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr closed issue #61086: Don't use isinstance for latest runs statement in dag processing
URL: https://github.com/apache/airflow/issues/61086
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org