You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Suresh Srinivas (JIRA)" <ji...@apache.org> on 2009/05/16 00:09:45 UTC
[jira] Created: (HADOOP-5853) Undeprecate
HttpServer.addInternalServlet method to fix findbugs warnings
Undeprecate HttpServer.addInternalServlet method to fix findbugs warnings
-------------------------------------------------------------------------
Key: HADOOP-5853
URL: https://issues.apache.org/jira/browse/HADOOP-5853
Project: Hadoop Core
Issue Type: Bug
Reporter: Suresh Srinivas
Assignee: Suresh Srinivas
Fix For: 0.21.0
Deprecated method {{HttpServer.addInternalServlet()}} causes many java warnings. Next comment covers the reason for undeprecating the method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5853) Undeprecate
HttpServer.addInternalServlet method to fix javac warnings
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-5853:
------------------------------------
Status: Patch Available (was: Open)
> Undeprecate HttpServer.addInternalServlet method to fix javac warnings
> ----------------------------------------------------------------------
>
> Key: HADOOP-5853
> URL: https://issues.apache.org/jira/browse/HADOOP-5853
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.21.0
>
> Attachments: 5853.patch
>
>
> Deprecated method {{HttpServer.addInternalServlet()}} causes many java warnings. Next comment covers the reason for undeprecating the method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5853) Undeprecate
HttpServer.addInternalServlet method to fix findbugs warnings
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5853:
-------------------------------------------
Hadoop Flags: [Reviewed]
+1 patch looks good
(should this fix javac warnings instead findbugs?)
> Undeprecate HttpServer.addInternalServlet method to fix findbugs warnings
> -------------------------------------------------------------------------
>
> Key: HADOOP-5853
> URL: https://issues.apache.org/jira/browse/HADOOP-5853
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.21.0
>
> Attachments: 5853.patch
>
>
> Deprecated method {{HttpServer.addInternalServlet()}} causes many java warnings. Next comment covers the reason for undeprecating the method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5853) Undeprecate
HttpServer.addInternalServlet method to fix javac warnings
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-5853:
------------------------------------
Summary: Undeprecate HttpServer.addInternalServlet method to fix javac warnings (was: Undeprecate HttpServer.addInternalServlet method to fix findbugs warnings)
> Undeprecate HttpServer.addInternalServlet method to fix javac warnings
> ----------------------------------------------------------------------
>
> Key: HADOOP-5853
> URL: https://issues.apache.org/jira/browse/HADOOP-5853
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.21.0
>
> Attachments: 5853.patch
>
>
> Deprecated method {{HttpServer.addInternalServlet()}} causes many java warnings. Next comment covers the reason for undeprecating the method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5853) Undeprecate
HttpServer.addInternalServlet method to fix javac warnings
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710030#action_12710030 ]
Suresh Srinivas commented on HADOOP-5853:
-----------------------------------------
Here is the result of test-patch result. No test cases added because the change only undeprecates a method. I am not sure what is triggering eclipse classpath and release audit warnings
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] -1 Eclipse classpath. The patch causes the Eclipse classpath to differ from the contents of the lib directories.
[exec]
[exec] -1 release audit. The applied patch generated 490 release audit warnings (more than the trunk's current 488 warnings).
> Undeprecate HttpServer.addInternalServlet method to fix javac warnings
> ----------------------------------------------------------------------
>
> Key: HADOOP-5853
> URL: https://issues.apache.org/jira/browse/HADOOP-5853
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.21.0
>
> Attachments: 5853.patch
>
>
> Deprecated method {{HttpServer.addInternalServlet()}} causes many java warnings. Next comment covers the reason for undeprecating the method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5853) Undeprecate
HttpServer.addInternalServlet method to fix javac warnings
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710033#action_12710033 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-5853:
------------------------------------------------
> I am not sure what is triggering eclipse classpath and release audit warnings
I think you might have done something wrong. Could you try ant test-patch again?
> Undeprecate HttpServer.addInternalServlet method to fix javac warnings
> ----------------------------------------------------------------------
>
> Key: HADOOP-5853
> URL: https://issues.apache.org/jira/browse/HADOOP-5853
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.21.0
>
> Attachments: 5853.patch
>
>
> Deprecated method {{HttpServer.addInternalServlet()}} causes many java warnings. Next comment covers the reason for undeprecating the method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5853) Undeprecate
HttpServer.addInternalServlet method to fix findbugs warnings
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-5853:
------------------------------------
Attachment: 5853.patch
> Undeprecate HttpServer.addInternalServlet method to fix findbugs warnings
> -------------------------------------------------------------------------
>
> Key: HADOOP-5853
> URL: https://issues.apache.org/jira/browse/HADOOP-5853
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.21.0
>
> Attachments: 5853.patch
>
>
> Deprecated method {{HttpServer.addInternalServlet()}} causes many java warnings. Next comment covers the reason for undeprecating the method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5853) Undeprecate
HttpServer.addInternalServlet method to fix javac warnings
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710832#action_12710832 ]
Suresh Srinivas commented on HADOOP-5853:
-----------------------------------------
After running the tests again, I do not see eclipse classpath issue. However the release audit is still being printed. The two new warnings are:
[javadoc] JDiff: warning: change from deprecated to undeprecated for method FileSystem.isDirectory
[javadoc] JDiff: warning: change from deprecated to undeprecated for method HttpServer.addInternalServlet
First one comes from a change that was made earlier. The second undeprecation is the intent of this patch. I propose committing this patch, given the release audit warning is expected.
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec] -1 release audit. The applied patch generated 496 release audit warnings (more than the trunk's current 494 warnings).
> Undeprecate HttpServer.addInternalServlet method to fix javac warnings
> ----------------------------------------------------------------------
>
> Key: HADOOP-5853
> URL: https://issues.apache.org/jira/browse/HADOOP-5853
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.21.0
>
> Attachments: 5853.patch
>
>
> Deprecated method {{HttpServer.addInternalServlet()}} causes many java warnings. Next comment covers the reason for undeprecating the method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5853) Undeprecate
HttpServer.addInternalServlet method to fix javac warnings
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5853:
-------------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I have committed this. Thanks, Suresh!
> Undeprecate HttpServer.addInternalServlet method to fix javac warnings
> ----------------------------------------------------------------------
>
> Key: HADOOP-5853
> URL: https://issues.apache.org/jira/browse/HADOOP-5853
> Project: Hadoop Core
> Issue Type: Bug
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Fix For: 0.21.0
>
> Attachments: 5853.patch
>
>
> Deprecated method {{HttpServer.addInternalServlet()}} causes many java warnings. Next comment covers the reason for undeprecating the method.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.