You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by Julian Reschke <ju...@gmx.de> on 2024/02/22 13:58:37 UTC
[VOTE] Release Apache Jackrabbit 2.21.25
A candidate for the Jackrabbit 2.21.25 release is available at:
https://dist.apache.org/repos/dist/dev/jackrabbit/2.21.25/
The release candidate is a zip archive of the sources in:
https://svn.apache.org/repos/asf/jackrabbit/tags/jackrabbit-2.21.25/
The SHA1 checksum of the archive is
8be7d1668efe0dd8ce0a0fccc7ab2e1c8afd1ebd.
A staged Maven repository is available for review at:
https://repository.apache.org/
The command for running automated checks against this release candidate is:
# run in SVN checkout of
https://dist.apache.org/repos/dist/dev/jackrabbit/
$ sh check-release.sh jackrabbit 2.21.25
8be7d1668efe0dd8ce0a0fccc7ab2e1c8afd1ebd
Please vote on releasing this package as Apache Jackrabbit 2.21.25.
The vote is open for the next 72 hours and passes if a majority of at
least three +1 Jackrabbit PMC votes are cast.
[ ] +1 Release this package as Apache Jackrabbit 2.21.25
[ ] -1 Do not release this package because...
Best regards, Julian
Re: [VOTE] Release Apache Jackrabbit 2.21.25
Posted by Woonsan Ko <wo...@apache.org>.
[X] +1 Release this package as Apache Jackrabbit 2.21.25
...where...
[INFO] Apache Maven 3.9.6 (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
[INFO] OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
[INFO] Java version: 11.0.2, vendor: Oracle Corporation, runtime:
C:\Java\jdk-11.0.2
[INFO] MAVEN_OPTS:
Regards,
Woonsan
On Thu, Feb 22, 2024 at 10:58 PM Julian Reschke <ju...@gmx.de> wrote:
>
> A candidate for the Jackrabbit 2.21.25 release is available at:
>
> https://dist.apache.org/repos/dist/dev/jackrabbit/2.21.25/
>
> The release candidate is a zip archive of the sources in:
>
> https://svn.apache.org/repos/asf/jackrabbit/tags/jackrabbit-2.21.25/
>
> The SHA1 checksum of the archive is
> 8be7d1668efe0dd8ce0a0fccc7ab2e1c8afd1ebd.
>
> A staged Maven repository is available for review at:
>
> https://repository.apache.org/
>
> The command for running automated checks against this release candidate is:
>
> # run in SVN checkout of
> https://dist.apache.org/repos/dist/dev/jackrabbit/
> $ sh check-release.sh jackrabbit 2.21.25
> 8be7d1668efe0dd8ce0a0fccc7ab2e1c8afd1ebd
>
> Please vote on releasing this package as Apache Jackrabbit 2.21.25.
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 Jackrabbit PMC votes are cast.
>
> [ ] +1 Release this package as Apache Jackrabbit 2.21.25
> [ ] -1 Do not release this package because...
>
> Best regards, Julian
[RESULT] [VOTE] Release Apache Jackrabbit 2.21.25
Posted by Julian Reschke <ju...@gmx.de>.
On 22.02.2024 14:58, Julian Reschke wrote:
> ...
Hi there,
The vote passes as follows:
+1 Julian Reschke <ju...@gmx.de>
+1 Manfred Baedke <ma...@gmail.com>
+1 Woonsan Ko <wo...@apache.org>
Thanks for voting. I'll push the release out.
Best regards, Julian
Re: [VOTE] Release Apache Jackrabbit 2.21.25
Posted by Julian Reschke <ju...@gmx.de>.
On 22.02.2024 14:58, Julian Reschke wrote:
> ...
[X] +1 Release this package as Apache Jackrabbit 2.21.25
...where...
> [INFO] Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
> [INFO] OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
> [INFO] Java version: 11.0.20, vendor: Oracle Corporation, runtime: C:\usr\local\jdk-11.0.20
> [INFO] MAVEN_OPTS: -Xmx2g
Best regards, Julian
Re: [VOTE] Release Apache Jackrabbit 2.21.25
Posted by Manfred Baedke <ma...@gmail.com>.
[X] +1 Release this package as Apache Jackrabbit 2.21.25
with
[INFO] Apache Maven 3.6.3
[INFO] OS name: "linux", version: "6.1.0-1033-oem", arch: "amd64", family:
"unix"
[INFO] Java version: 11.0.21, vendor: Ubuntu, runtime:
/usr/lib/jvm/java-11-openjdk-amd64
[INFO] MAVEN_OPTS:
[INFO]
------------------------------------------------------------------------
[INFO] ALL CHECKS OK
Am Do., 22. Feb. 2024 um 14:58 Uhr schrieb Julian Reschke <
julian.reschke@gmx.de>:
> A candidate for the Jackrabbit 2.21.25 release is available at:
>
> https://dist.apache.org/repos/dist/dev/jackrabbit/2.21.25/
>
> The release candidate is a zip archive of the sources in:
>
> https://svn.apache.org/repos/asf/jackrabbit/tags/jackrabbit-2.21.25/
>
> The SHA1 checksum of the archive is
> 8be7d1668efe0dd8ce0a0fccc7ab2e1c8afd1ebd.
>
> A staged Maven repository is available for review at:
>
> https://repository.apache.org/
>
> The command for running automated checks against this release candidate is:
>
> # run in SVN checkout of
> https://dist.apache.org/repos/dist/dev/jackrabbit/
> $ sh check-release.sh jackrabbit 2.21.25
> 8be7d1668efe0dd8ce0a0fccc7ab2e1c8afd1ebd
>
> Please vote on releasing this package as Apache Jackrabbit 2.21.25.
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 Jackrabbit PMC votes are cast.
>
> [ ] +1 Release this package as Apache Jackrabbit 2.21.25
> [ ] -1 Do not release this package because...
>
> Best regards, Julian
>
Re: [VOTE] Release Apache Jackrabbit 2.21.25
Posted by Julian Reschke <ju...@gmx.de>.
On 24.02.2024 00:40, Herve Boutemy wrote:
> On 2024/02/23 16:15:06 Julian Reschke wrote:
>>> Can the check-release.sh be updated, please?
>>
>> Right now, we can't. a) Because we share the script with Oak (which is
>> known not to have reproducable builds),
>
> ok, I'll work on it
>
>>>> and the environment doing the release fixed?
>>>
>>> If I understood what the problem is I'll be happy to fix it.
>>> ...
>>
>> So it seems that the weird permissions are caused by the fact that my
>> WSL instance uses a local maven repo mounted from a Windows FS. Once I
>> move to a Linux-native repo, the permissions are different.
>
> thank you for the explanation of the root cause: this is the first time I see this one, with some good surprises (newline) and some bad ones (executable)
>
>> I can try this for the next release (and the downside of course is disk
>> space impact on the release machine). It would be better if we could
>> tell the plugin generating the WAR file to normalize the permissions;
>> otherwise the build will always depend on the setting in the local maven
>> repo.
>
> now that I understand why it is needed, I suppose I can add the feature to maven-war-plugin: I'll work on it and propose a PR to jackrabbit
>
> thanks for the feedback
> changing my vote to +1, given there is a clear explanation (having a plan to solve is even better)
>
> Best regards,
>
> Hervé
Thanks :-)
Best regards, Julian
Re: [VOTE] Release Apache Jackrabbit 2.21.25
Posted by Herve Boutemy <hb...@apache.org>.
On 2024/02/23 16:15:06 Julian Reschke wrote:
> > Can the check-release.sh be updated, please?
>
> Right now, we can't. a) Because we share the script with Oak (which is
> known not to have reproducable builds),
ok, I'll work on it
> >> and the environment doing the release fixed?
> >
> > If I understood what the problem is I'll be happy to fix it.
> > ...
>
> So it seems that the weird permissions are caused by the fact that my
> WSL instance uses a local maven repo mounted from a Windows FS. Once I
> move to a Linux-native repo, the permissions are different.
thank you for the explanation of the root cause: this is the first time I see this one, with some good surprises (newline) and some bad ones (executable)
> I can try this for the next release (and the downside of course is disk
> space impact on the release machine). It would be better if we could
> tell the plugin generating the WAR file to normalize the permissions;
> otherwise the build will always depend on the setting in the local maven
> repo.
now that I understand why it is needed, I suppose I can add the feature to maven-war-plugin: I'll work on it and propose a PR to jackrabbit
thanks for the feedback
changing my vote to +1, given there is a clear explanation (having a plan to solve is even better)
Best regards,
Hervé
Re: [VOTE] Release Apache Jackrabbit 2.21.25
Posted by Julian Reschke <ju...@gmx.de>.
On 23.02.2024 16:29, Julian Reschke wrote:
> On 23.02.2024 00:04, Herve Boutemy wrote:
>> -1 non-binding, jackrabbit-webapp-2.21.25.war has executable flags for
>> dependencies in WEB-INF/lib
>>
>> in check-release.sh line 230, changing
>> exec mvn --batch-mode clean verify $MVN_ARGS
>> to
>> exec mvn --batch-mode clean verify artifact:compare
>> -Dreference.repo=https://repository.apache.org/content/repositories/staging/ $MVN_ARGS
>>
>> permits to check jars that will be published to Maven Central
>>
>> And sadly, jackrabbit-webapp-2.21.25.war is not ok: same issue as
>> previous releases, due to executable flag
>>
>>
>> Can the check-release.sh be updated, please?
>
> Right now, we can't. a) Because we share the script with Oak (which is
> known not to have reproducable builds), and b) because it would fail the
> check for Jackabbit when this is clearly not a regression (yet).
>
>> and the environment doing the release fixed?
>
> If I understood what the problem is I'll be happy to fix it.
> ...
So it seems that the weird permissions are caused by the fact that my
WSL instance uses a local maven repo mounted from a Windows FS. Once I
move to a Linux-native repo, the permissions are different.
I can try this for the next release (and the downside of course is disk
space impact on the release machine). It would be better if we could
tell the plugin generating the WAR file to normalize the permissions;
otherwise the build will always depend on the setting in the local maven
repo.
Best regards, Julian
Re: [VOTE] Release Apache Jackrabbit 2.21.25
Posted by Julian Reschke <ju...@gmx.de>.
On 23.02.2024 00:04, Herve Boutemy wrote:
> -1 non-binding, jackrabbit-webapp-2.21.25.war has executable flags for dependencies in WEB-INF/lib
>
> in check-release.sh line 230, changing
> exec mvn --batch-mode clean verify $MVN_ARGS
> to
> exec mvn --batch-mode clean verify artifact:compare -Dreference.repo=https://repository.apache.org/content/repositories/staging/ $MVN_ARGS
>
> permits to check jars that will be published to Maven Central
>
> And sadly, jackrabbit-webapp-2.21.25.war is not ok: same issue as previous releases, due to executable flag
>
>
> Can the check-release.sh be updated, please?
Right now, we can't. a) Because we share the script with Oak (which is
known not to have reproducable builds), and b) because it would fail the
check for Jackabbit when this is clearly not a regression (yet).
> and the environment doing the release fixed?
If I understood what the problem is I'll be happy to fix it.
> this would bring you the first release that is proven fully reproducible:
> https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/jackrabbit/jackrabbit/README.md
>
> Regards,
>
> Hervé
Best regards, Julian
Re: [VOTE] Release Apache Jackrabbit 2.21.25
Posted by Herve Boutemy <hb...@apache.org>.
-1 non-binding, jackrabbit-webapp-2.21.25.war has executable flags for dependencies in WEB-INF/lib
in check-release.sh line 230, changing
exec mvn --batch-mode clean verify $MVN_ARGS
to
exec mvn --batch-mode clean verify artifact:compare -Dreference.repo=https://repository.apache.org/content/repositories/staging/ $MVN_ARGS
permits to check jars that will be published to Maven Central
And sadly, jackrabbit-webapp-2.21.25.war is not ok: same issue as previous releases, due to executable flag
Can the check-release.sh be updated, please?
and the environment doing the release fixed?
this would bring you the first release that is proven fully reproducible:
https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/jackrabbit/jackrabbit/README.md
Regards,
Hervé
On 2024/02/22 13:58:37 Julian Reschke wrote:
> A candidate for the Jackrabbit 2.21.25 release is available at:
>
> https://dist.apache.org/repos/dist/dev/jackrabbit/2.21.25/
>
> The release candidate is a zip archive of the sources in:
>
> https://svn.apache.org/repos/asf/jackrabbit/tags/jackrabbit-2.21.25/
>
> The SHA1 checksum of the archive is
> 8be7d1668efe0dd8ce0a0fccc7ab2e1c8afd1ebd.
>
> A staged Maven repository is available for review at:
>
> https://repository.apache.org/
>
> The command for running automated checks against this release candidate is:
>
> # run in SVN checkout of
> https://dist.apache.org/repos/dist/dev/jackrabbit/
> $ sh check-release.sh jackrabbit 2.21.25
> 8be7d1668efe0dd8ce0a0fccc7ab2e1c8afd1ebd
>
> Please vote on releasing this package as Apache Jackrabbit 2.21.25.
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 Jackrabbit PMC votes are cast.
>
> [ ] +1 Release this package as Apache Jackrabbit 2.21.25
> [ ] -1 Do not release this package because...
>
> Best regards, Julian
>