[jira] [Comment Edited] (CALCITE-3281) Support mixed Primitive types for BinaryExpression evaluate method.

["Julian Hyde (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-3281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16913006#comment-16913006 ] 

Julian Hyde edited comment on CALCITE-3281 at 8/22/19 6:20 AM:
---------------------------------------------------------------

Could
{code}
      case INT:
        return (Integer) getValue(expression0.evaluate(evaluator), primitive)
            + (Integer) getValue(expression1.evaluate(evaluator), primitive);
{code}
be replaced with
{code}
      case INT:
        return expression0.evaluateInt(evaluator)
            + expression1.evaluateInt(evaluator);
{code}
where
{code}
   int evaluateInt(Evaluator evaluator) {
     return ((Number) evaluate(evaluator)).intValue();
  }
{code}

The latter form is more concise and perhaps a little more efficient.


was (Author: julianhyde):
Could
```
      case INT:
        return (Integer) getValue(expression0.evaluate(evaluator), primitive)
            + (Integer) getValue(expression1.evaluate(evaluator), primitive);
```
be replaced with
```
      case INT:
        return expression0.evaluateInt(evaluator)
            + expression1.evaluateInt(evaluator);
```
where
```
   int evaluateInt(Evaluator evaluator) {
     return ((Number) evaluate(evaluator)).intValue();
  }
```

The latter form is more concise and perhaps a little more efficient.

>  Support mixed Primitive types for BinaryExpression evaluate method.
> --------------------------------------------------------------------
>
>                 Key: CALCITE-3281
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3281
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Wang Yanlin
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently, the value of [expression0 and expression1 |https://github.com/apache/calcite/blob/master/linq4j/src/main/java/org/apache/calcite/linq4j/tree/BinaryExpression.java#L26] must be the same type.
> Otherwise, when evaluate, we will get a ClassCastException, something like this
> {code:java}
> java.lang.ClassCastException: java.lang.Integer cannot be cast to java.lang.Long
> 	at org.apache.calcite.linq4j.tree.BinaryExpression.evaluate(BinaryExpression.java:75)
> 	at org.apache.calcite.linq4j.tree.GotoStatement.evaluate(GotoStatement.java:97)
> 	at org.apache.calcite.linq4j.tree.BlockStatement.evaluate(BlockStatement.java:83)
> 	at org.apache.calcite.linq4j.tree.Evaluator.evaluate(Evaluator.java:55)
> 	at org.apache.calcite.linq4j.tree.FunctionExpression.lambda$compile$0(FunctionExpression.java:87)
> 	at org.apache.calcite.linq4j.test.ExpressionTest.testLambdaCallsBinaryOpMixType(ExpressionTest.java:349)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> 	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> 	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> 	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> 	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> 	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> 	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> 	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> 	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> 	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
> 	at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
> 	at com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:47)
> 	at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
> 	at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
> {code}
> Actually, we can do something to support mixed primitive types in BinaryExpression.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)