You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/04 05:36:44 UTC

[GitHub] [pulsar] srkukarni commented on a change in pull request #7165: Attach names for all producers/readers in worker service

srkukarni commented on a change in pull request #7165:
URL: https://github.com/apache/pulsar/pull/7165#discussion_r435002727



##########
File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionMetaDataManager.java
##########
@@ -91,6 +91,7 @@ public void initialize() {
             Reader<byte[]> reader = pulsarClient.newReader()
                     .topic(this.workerConfig.getFunctionMetadataTopic())
                     .startMessageId(MessageId.earliest)
+                    .readerName(workerConfig.getWorkerId() + "-function-metadata-manager")

Review comment:
       I would rather prefer it to be more specific than just assumed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org