You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "hailin0 (via GitHub)" <gi...@apache.org> on 2024/01/15 13:43:51 UTC

[PR] [Feature][Oracle-CDC] Support custom table primary key [seatunnel]

hailin0 opened a new pull request, #6216:
URL: https://github.com/apache/seatunnel/pull/6216

   ### Purpose of this pull request
   
   [Oracle-CDC] Support custom table primary key
   link https://github.com/apache/seatunnel/pull/6106/
   
   ### Does this PR introduce _any_ user-facing change?
   Add new config key
   
   
   ### How was this patch tested?
   Added
   
   
   ### Check list
   
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
   * [ ] If you are contributing the connector code, please check that the following files are updated:
     1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/seatunnel/tree/dev/docs/en/connector-v2)
     2. Update [plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
     3. Update the pom file of [seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
   * [ ] Update the [`release-note`](https://github.com/apache/seatunnel/blob/dev/release-note.md).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Feature][Oracle-CDC] Support custom table primary key [seatunnel]

Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 merged PR #6216:
URL: https://github.com/apache/seatunnel/pull/6216


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Feature][Oracle-CDC] Support custom table primary key [seatunnel]

Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on code in PR #6216:
URL: https://github.com/apache/seatunnel/pull/6216#discussion_r1453451718


##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-oracle-e2e/src/test/java/org/apache/seatunnel/connectors/seatunnel/cdc/oracle/OracleCDCIT.java:
##########
@@ -221,6 +221,52 @@ public void testOracleCdcCheckDataWithNoPrimaryKey(TestContainer container) thro
                         });
     }
 
+    @TestTemplate
+    public void testOracleCdcCheckDataWithCustomPrimaryKey(TestContainer container)

Review Comment:
   this e2e is passed
   <img width="1469" alt="image" src="https://github.com/apache/seatunnel/assets/14371345/2af90a93-dde7-4c27-b2dd-e9d4ed928166">
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org