You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/10/11 20:06:29 UTC
[GitHub] [iceberg] aokolnychyi commented on a change in pull request #3256: Build: Move Spark version modules under spark directory
aokolnychyi commented on a change in pull request #3256:
URL: https://github.com/apache/iceberg/pull/3256#discussion_r726538685
##########
File path: jmh.gradle
##########
@@ -19,9 +19,9 @@
def jmhProjects = []
if (JavaVersion.current() == JavaVersion.VERSION_1_8) {
- jmhProjects = [ project("iceberg-spark2"), project("iceberg-spark3") ]
+ jmhProjects = [ project(":iceberg-spark:iceberg-spark2"), project(":iceberg-spark:iceberg-spark3") ]
Review comment:
Does it have to be `:iceberg-spark:spark2` and `:iceberg-spark:spark3`?
##########
File path: jmh.gradle
##########
@@ -19,9 +19,9 @@
def jmhProjects = []
if (JavaVersion.current() == JavaVersion.VERSION_1_8) {
- jmhProjects = [ project("iceberg-spark2"), project("iceberg-spark3") ]
+ jmhProjects = [ project(":iceberg-spark:iceberg-spark2"), project(":iceberg-spark:iceberg-spark3") ]
Review comment:
Doesn't it have to be `:iceberg-spark:spark2` and `:iceberg-spark:spark3`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org