[jira] [Comment Edited] (IGNITE-11152) IgniteTxManager.idMap possible memory leak

["Roman Kondakov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-11152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16784350#comment-16784350 ] 

Roman Kondakov edited comment on IGNITE-11152 at 3/5/19 1:47 PM:
-----------------------------------------------------------------

[~vozerov], [~amashenkov], tests look good. Patch is ready for review.

What was broken: {{RuntimeException}} handling was missed in {{GridCacheAdapter#syncOp}} and because of this, current active transaction was not rolled back and it wasn't removed from  TxManager maps.


was (Author: rkondakov):
[~vozerov], [~amashenkov], tests look good. Patch is ready for review.

> IgniteTxManager.idMap possible memory leak
> ------------------------------------------
>
>                 Key: IGNITE-11152
>                 URL: https://issues.apache.org/jira/browse/IGNITE-11152
>             Project: Ignite
>          Issue Type: Bug
>          Components: mvcc
>            Reporter: Stepachev Maksim
>            Assignee: Roman Kondakov
>            Priority: Major
>              Labels: memory-leak, mvcc_stabilization_stage_1, transactions
>             Fix For: 2.8
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> CacheContinuousQueryAsyncFailoverMvccTxSelfTest.testMultiThreadedFailover sometimes finished with OMM.
> Heapdump analyze showed that leak happened in IgniteTxManager.idMap, this map contains *2_097_152* instances of GridNearTxLocal with *ACTIVE state* and *without* finishFut *and prepFut.*
>  
> {code:java}
> while (!updated) {
>  try {
>  prevVal = (Integer)qryClnCache.getAndPut(key, val);
> updated = true;
>  }
>  catch (CacheException e) {
>  assertSame(atomicityMode(), CacheAtomicityMode.TRANSACTIONAL_SNAPSHOT);
>  }
>  }
> {code}
>  
>  
> Possible the CacheException is common and may hide wrong cases. Change it at specific (ignite-10976).  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)