You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2020/07/20 15:48:28 UTC

[GitHub] [trafficserver] bneradt commented on a change in pull request #7013: Update autest python version to 36

bneradt commented on a change in pull request #7013:
URL: https://github.com/apache/trafficserver/pull/7013#discussion_r457511190



##########
File path: tests/bootstrap.py
##########
@@ -26,7 +26,7 @@
 import sys
 
 pip_packages = [
-    "autest==1.7.3",
+    "autest==1.7.4",

Review comment:
       Any reason not to go to 1.8.0? One of the fixes in 1.8.0 fixes Process cleanup function dispatch. Without that, we don't recycle ports as expected from this cleanup function from autest-site/ports.py:
   
   https://github.com/ezelkow1/trafficserver/blob/81x-autest/tests/gold_tests/autest-site/ports.py#L118
   
   That bug eventually results in us running out of safe ports and we have to fall back to a less optimal "bind, get the port, release" mechanism which has a rare race condition which could lead to an EADDRINUSE error.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org