[TCK] JSTL failure

[Jean-Louis MONTEIRO <je...@gmail.com>]

Hi,

I have been using Tomcat Taglib (shaded with Xalan and Serializer).
Works quite well on TomEE but I have one failure I'd like to discuss with
you before possibly opening a challenge.

https://tck.work/tomee/tests?path=com.sun.ts.tests.jstl&build=1608116575927&status=FAILED

I have fixed 4 or the 5,
but com.sun.ts.tests.jstl.spec.core.urlresource.importtag.JSTLClient is
still failing and I don't understand how to fix it.

Here is the JSP
https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/web/jstl/spec/core/urlresource/importtag/positiveImportEncodingNotSpecifiedTest.jsp

Here is the expected result
https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/web/jstl/spec/core/urlresource/importtag/positiveImportEncodingNotSpecifiedTest.gf

The first file imported is
https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/web/jstl/spec/core/urlresource/importtag/encoding/Encoding.jsp

And the second
https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/web/jstl/spec/core/urlresource/importtag/import-encoded.txt

In the golden file, there seems to be 2 extra characters.
Here is the full log file for the test run

https://tck.work/tomee/api/testlog/1218/1608116849515

Any thoughts?
The result from Tomcat looks ok to me unless I missed something.



-- 
Jean-Louis

Re: [TCK] JSTL failure

[Jonathan Gallimore <jo...@gmail.com>]

Looking at this again, those characters are a BOM, and having that in the
middle of the output seems a little strange. I'd suggest asking on the spec
list.

Jon

On Thu, Dec 17, 2020 at 10:51 AM Jonathan Gallimore <
jonathan.gallimore@gmail.com> wrote:

> I opened both the import-encoded.txt, and the
> positiveImportEncodingNotSpecifiedTest.gf file in a hex editor. I don't
> know if this mailing list allows attachments, but I can send a screenshot
> if that helps. In both cases, right before the word "output from text
> file", there's a sequence of 4 bytes 0xFE, 0xFF, 0x00, 0x6F. The 0x6F is
> the "o" on "output", so it looks like the 0xFF 0xFE is being dropped
> somewhere. The test sounds ok (although maybe not straightforward to
> understand). On the TomEE side, I think we need to understand whether this
> is an issue with our use of shading to include Xalan, or whether we'd still
> see this issue if we included Xalan etc manually without shading.
>
> Jon
>
> On Thu, Dec 17, 2020 at 8:27 AM Jean-Louis MONTEIRO <je...@gmail.com>
> wrote:
>
>> Hi,
>>
>> I have been using Tomcat Taglib (shaded with Xalan and Serializer).
>> Works quite well on TomEE but I have one failure I'd like to discuss with
>> you before possibly opening a challenge.
>>
>>
>> https://tck.work/tomee/tests?path=com.sun.ts.tests.jstl&build=1608116575927&status=FAILED
>>
>> I have fixed 4 or the 5,
>> but com.sun.ts.tests.jstl.spec.core.urlresource.importtag.JSTLClient is
>> still failing and I don't understand how to fix it.
>>
>> Here is the JSP
>>
>> https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/web/jstl/spec/core/urlresource/importtag/positiveImportEncodingNotSpecifiedTest.jsp
>>
>> Here is the expected result
>>
>> https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/web/jstl/spec/core/urlresource/importtag/positiveImportEncodingNotSpecifiedTest.gf
>>
>> The first file imported is
>>
>> https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/web/jstl/spec/core/urlresource/importtag/encoding/Encoding.jsp
>>
>> And the second
>>
>> https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/web/jstl/spec/core/urlresource/importtag/import-encoded.txt
>>
>> In the golden file, there seems to be 2 extra characters.
>> Here is the full log file for the test run
>>
>> https://tck.work/tomee/api/testlog/1218/1608116849515
>>
>> Any thoughts?
>> The result from Tomcat looks ok to me unless I missed something.
>>
>>
>>
>> --
>> Jean-Louis
>>
>

Re: [TCK] JSTL failure

[Jonathan Gallimore <jo...@gmail.com>]

I opened both the import-encoded.txt, and the
positiveImportEncodingNotSpecifiedTest.gf file in a hex editor. I don't
know if this mailing list allows attachments, but I can send a screenshot
if that helps. In both cases, right before the word "output from text
file", there's a sequence of 4 bytes 0xFE, 0xFF, 0x00, 0x6F. The 0x6F is
the "o" on "output", so it looks like the 0xFF 0xFE is being dropped
somewhere. The test sounds ok (although maybe not straightforward to
understand). On the TomEE side, I think we need to understand whether this
is an issue with our use of shading to include Xalan, or whether we'd still
see this issue if we included Xalan etc manually without shading.

Jon

On Thu, Dec 17, 2020 at 8:27 AM Jean-Louis MONTEIRO <je...@gmail.com>
wrote:

> Hi,
>
> I have been using Tomcat Taglib (shaded with Xalan and Serializer).
> Works quite well on TomEE but I have one failure I'd like to discuss with
> you before possibly opening a challenge.
>
>
> https://tck.work/tomee/tests?path=com.sun.ts.tests.jstl&build=1608116575927&status=FAILED
>
> I have fixed 4 or the 5,
> but com.sun.ts.tests.jstl.spec.core.urlresource.importtag.JSTLClient is
> still failing and I don't understand how to fix it.
>
> Here is the JSP
>
> https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/web/jstl/spec/core/urlresource/importtag/positiveImportEncodingNotSpecifiedTest.jsp
>
> Here is the expected result
>
> https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/web/jstl/spec/core/urlresource/importtag/positiveImportEncodingNotSpecifiedTest.gf
>
> The first file imported is
>
> https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/web/jstl/spec/core/urlresource/importtag/encoding/Encoding.jsp
>
> And the second
>
> https://github.com/eclipse-ee4j/jakartaee-tck/blob/master/src/web/jstl/spec/core/urlresource/importtag/import-encoded.txt
>
> In the golden file, there seems to be 2 extra characters.
> Here is the full log file for the test run
>
> https://tck.work/tomee/api/testlog/1218/1608116849515
>
> Any thoughts?
> The result from Tomcat looks ok to me unless I missed something.
>
>
>
> --
> Jean-Louis
>