Re: [PR] KAFKA-18001: Support UpdateRaftVoterRequest in KafkaNetworkChannel [kafka]

["justinrlee (via GitHub)" <gi...@apache.org>]

justinrlee commented on code in PR #17773:
URL: https://github.com/apache/kafka/pull/17773#discussion_r1841861864


##########
raft/src/main/java/org/apache/kafka/raft/KafkaNetworkChannel.java:
##########
@@ -187,6 +189,8 @@ static AbstractRequest.Builder<? extends AbstractRequest> buildRequest(ApiMessag
             return new FetchRequest.SimpleBuilder((FetchRequestData) requestData);
         if (requestData instanceof FetchSnapshotRequestData)
             return new FetchSnapshotRequest.Builder((FetchSnapshotRequestData) requestData);
+        if (requestData instanceof UpdateRaftVoterRequestData)

Review Comment:
   FWIW, I don't see any errors when I use `remove-controller` so it doesn't look like we need to support this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org