[GitHub] [helix] rahulrane50 commented on a diff in pull request #2553: Adding logs for missing top state metrics reporting.

["rahulrane50 (via GitHub)" <gi...@apache.org>]

rahulrane50 commented on code in PR #2553:
URL: https://github.com/apache/helix/pull/2553#discussion_r1259039445


##########
helix-core/src/main/java/org/apache/helix/controller/stages/TopStateHandoffReportStage.java:
##########
@@ -469,16 +475,17 @@ private void reportTopStateComesBack(ResourceControllerDataProvider cache, Map<S
       }
     }
 
+    long duration = handOffEndTime - handOffStartTime;
+    long helixLatency = duration - fromTopStateUserLatency - toTopStateUserLatency;
+    // It is possible that during controller leader switch, we lost previous master information
+    // and use current time to approximate missing top state start time. If we see the actual
+    // user latency is larger than the duration we estimated, we use user latency to start with
+    duration = Math.max(duration, helixLatency);
+    boolean isGraceful = record.isGracefulHandoff();
+    logMissingTopStateInfo(duration, helixLatency, isGraceful, partition.getPartitionName());
+    // TODO: Following threshold check can be removed and stats can be reported even if hand-off took more than
+    //  threshold.
     if (handOffStartTime > 0 && handOffEndTime - handOffStartTime <= threshold) {

Review Comment:
   Currently in this code path (when top state is recovered but handoff happened beyond threshold) we don't update the metric hence we don't log as well. But this makes it difficult to debug if we want to see what the exact handoff duration in this situation. Hence I moved just the logging upward but kept metric reporting as it is. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org