You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/04/26 01:39:51 UTC
[GitHub] [helix] pkuwm opened a new issue #971: Move ZK related tests from helix-core to zookeeper-api
pkuwm opened a new issue #971:
URL: https://github.com/apache/helix/issues/971
A new module zookeeper-api is created. But zk related tests are still in helix-core. If we would like to add a new test to an existing ZK test class in helix-core, we have to run all tests in helix-core and zookeeper-api. Our goal is we can run only tests in zookeeper-api.
Current reason why we don't move tests from helix-core to zookeeper-api is, some tests are mixed for helix-core and ZK and there are circular dependencies. It would benefit developers and make the structure clear if we can move ZK related tests to zookeeper-api.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly commented on issue #971: Move ZK related tests from helix-core to zookeeper-api
Posted by GitBox <gi...@apache.org>.
narendly commented on issue #971:
URL: https://github.com/apache/helix/issues/971#issuecomment-619501633
Let's also consider moving ZkTestHelper to zookeeper-api. We might want to make this available to users so that they could use it to write their integration tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org