[GitHub] [geode] jdeppe-pivotal opened pull request #2858: GEODE-5971: Refactor durable client commands to extend GfshCommand

["jdeppe-pivotal (GitHub)" <gi...@apache.org>]

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/2858 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on pull request #2858: GEODE-5971: Refactor durable client commands to extend GfshCommand

["jinmeiliao (GitHub)" <gi...@apache.org>]

I think we are trying to get away from using CliUtils in the command

[ Full content available at: https://github.com/apache/geode/pull/2858 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jdeppe-pivotal commented on pull request #2858: GEODE-5971: Refactor durable client commands to extend GfshCommand

["jdeppe-pivotal (GitHub)" <gi...@apache.org>]

Fixed

[ Full content available at: https://github.com/apache/geode/pull/2858 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jdeppe-pivotal closed pull request #2858: GEODE-5971: Refactor durable client commands to extend GfshCommand

["jdeppe-pivotal (GitHub)" <gi...@apache.org>]

[ pull request closed by jdeppe-pivotal ]

[ Full content available at: https://github.com/apache/geode/pull/2858 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jdeppe-pivotal commented on pull request #2858: GEODE-5971: Refactor durable client commands to extend GfshCommand

["jdeppe-pivotal (GitHub)" <gi...@apache.org>]

Fixed

[ Full content available at: https://github.com/apache/geode/pull/2858 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jdeppe-pivotal commented on pull request #2858: GEODE-5971: Refactor durable client commands to extend GfshCommand

["jdeppe-pivotal (GitHub)" <gi...@apache.org>]

Yes - removed.

[ Full content available at: https://github.com/apache/geode/pull/2858 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on pull request #2858: GEODE-5971: Refactor durable client commands to extend GfshCommand

["jinmeiliao (GitHub)" <gi...@apache.org>]

I think we should deprecate these methods in CommandResultAssert. these are used for the old CommandResult, for the ResultModel, the other assertions are much easier to understand.

[ Full content available at: https://github.com/apache/geode/pull/2858 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jinmeiliao commented on pull request #2858: GEODE-5971: Refactor durable client commands to extend GfshCommand

["jinmeiliao (GitHub)" <gi...@apache.org>]

I don't think these properties are needed.

[ Full content available at: https://github.com/apache/geode/pull/2858 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org