You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@daffodil.apache.org by "Steve Lawrence (Jira)" <ji...@apache.org> on 2021/02/04 20:38:00 UTC

[jira] [Updated] (DAFFODIL-2052) code quality: very poor identifiers - private def localElementPropertyReferencedElements(f: F)

     [ https://issues.apache.org/jira/browse/DAFFODIL-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Lawrence updated DAFFODIL-2052:
-------------------------------------
    Labels: beginner  (was: )

> code quality: very poor identifiers - private def localElementPropertyReferencedElements(f: F)
> ----------------------------------------------------------------------------------------------
>
>                 Key: DAFFODIL-2052
>                 URL: https://issues.apache.org/jira/browse/DAFFODIL-2052
>             Project: Daffodil
>          Issue Type: Improvement
>          Components: Clean Ups
>    Affects Versions: 2.2.0
>            Reporter: Mike Beckerle
>            Priority: Minor
>              Labels: beginner
>
> This method is using a type parameter.
> The name is "F". 
> This is ineffective at explaining what this is for. Choose better name, and enhance this code and surrounding class/trait with scaladoc of this type parameter so that we can understand what it does. 
> private def localElementPropertyReferencedElements(f: F)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)