You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by bharat kumar <bh...@citrix.com> on 2013/12/17 08:10:37 UTC

Review Request 16315: CLOUDSTACK-5495 Unable to stop VM

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16315/
-----------------------------------------------------------

Review request for cloudstack and Koushik Das.


Bugs: CLOUDSTACK-5495
    https://issues.apache.org/jira/browse/CLOUDSTACK-5495


Repository: cloudstack-git


Description
-------

CLOUDSTACK-5495 Unable to stop VM
This patch makes the execute.in.sequence.hypervisor.commands configurable for stopvm command.


Diffs
-----

  engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java bc6a32f 
  server/src/com/cloud/configuration/Config.java b994ce3 

Diff: https://reviews.apache.org/r/16315/diff/


Testing
-------

Tested on 4.3


Thanks,

bharat kumar

Re: Review Request 16315: CLOUDSTACK-5495 Unable to stop VM

Posted by Koushik Das <ko...@citrix.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16315/#review30526
-----------------------------------------------------------



engine/api/src/com/cloud/vm/VirtualMachineManager.java
<https://reviews.apache.org/r/16315/#comment58470>

    This need to be present in the list returned by getConfigKeys()



server/src/com/cloud/configuration/Config.java
<https://reviews.apache.org/r/16315/#comment58471>

    This should be removed as it is already defined in VirtualMachineManager.java


- Koushik Das


On Dec. 17, 2013, 9:38 a.m., bharat kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16315/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2013, 9:38 a.m.)
> 
> 
> Review request for cloudstack and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-5495
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5495
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-5495 Unable to stop VM
> This patch makes the execute.in.sequence.hypervisor.commands configurable for stopvm command.
> 
> 
> Diffs
> -----
> 
>   engine/api/src/com/cloud/vm/VirtualMachineManager.java f9bb935 
>   engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java bc6a32f 
>   server/src/com/cloud/configuration/Config.java b994ce3 
> 
> Diff: https://reviews.apache.org/r/16315/diff/
> 
> 
> Testing
> -------
> 
> Tested on 4.3
> 
> 
> Thanks,
> 
> bharat kumar
> 
>

Re: Review Request 16315: CLOUDSTACK-5495 Unable to stop VM

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16315/#review30528
-----------------------------------------------------------


Commit 9118bbf934292d0c95b04e9dff0b2f9a29251b80 in branch refs/heads/4.3 from Bharat Kumar
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=9118bbf ]

CLOUDSTACK-5495 Unable to stop VM. adding the changes to make the global config execute.in.sequence.hypervisor.commands configurable for stopvm command.

Signed-off-by: Koushik Das <ko...@apache.org>


- ASF Subversion and Git Services


On Dec. 17, 2013, 11:58 a.m., bharat kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16315/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2013, 11:58 a.m.)
> 
> 
> Review request for cloudstack and Koushik Das.
> 
> 
> Bugs: CLOUDSTACK-5495
>     https://issues.apache.org/jira/browse/CLOUDSTACK-5495
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> CLOUDSTACK-5495 Unable to stop VM
> This patch makes the execute.in.sequence.hypervisor.commands configurable for stopvm command.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/server/ManagementService.java ed46589 
>   engine/api/src/com/cloud/vm/VirtualMachineManager.java f9bb935 
>   engine/orchestration/src/com/cloud/vm/VirtualMachineManagerImpl.java bc6a32f 
>   engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java 67cc324 
>   server/src/com/cloud/configuration/Config.java b994ce3 
>   server/src/com/cloud/server/ManagementServer.java f60ce48 
>   server/src/com/cloud/server/ManagementServerImpl.java 0e9c483 
> 
> Diff: https://reviews.apache.org/r/16315/diff/
> 
> 
> Testing
> -------
> 
> Tested on 4.3
> 
> 
> Thanks,
> 
> bharat kumar
> 
>