You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/11/18 22:24:38 UTC

[Impala-ASF-CR] IMPALA-9166: undo inadvertant change testResourceRequirements

Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14737


Change subject: IMPALA-9166: undo inadvertant change testResourceRequirements
......................................................................

IMPALA-9166: undo inadvertant change testResourceRequirements

The limitation of this test output to Hive version 2 was
accidentally removed while manually merging planner tests.

Change-Id: Ia4791b117ddd42df2db5c01c529dd8ec850c5000
---
M testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test
1 file changed, 3 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/14737/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia4791b117ddd42df2db5c01c529dd8ec850c5000
Gerrit-Change-Number: 14737
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-9166: undo inadvertant change testResourceRequirements

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14737 )

Change subject: IMPALA-9166: undo inadvertant change testResourceRequirements
......................................................................

IMPALA-9166: undo inadvertant change testResourceRequirements

The limitation of this test output to Hive version 2 was
accidentally removed while manually merging planner tests.

Change-Id: Ia4791b117ddd42df2db5c01c529dd8ec850c5000
Reviewed-on: http://gerrit.cloudera.org:8080/14737
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/workloads/functional-planner/queries/PlannerTest/resource-requirements.test
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Joe McDonnell: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/14737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia4791b117ddd42df2db5c01c529dd8ec850c5000
Gerrit-Change-Number: 14737
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>

[Impala-ASF-CR] IMPALA-9166: undo inadvertant change testResourceRequirements

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14737 )

Change subject: IMPALA-9166: undo inadvertant change testResourceRequirements
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/5050/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/14737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4791b117ddd42df2db5c01c529dd8ec850c5000
Gerrit-Change-Number: 14737
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 Nov 2019 23:08:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9166: undo inadvertant change testResourceRequirements

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/14737 )

Change subject: IMPALA-9166: undo inadvertant change testResourceRequirements
......................................................................


Patch Set 1: Code-Review+2

Thanks!


-- 
To view, visit http://gerrit.cloudera.org:8080/14737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4791b117ddd42df2db5c01c529dd8ec850c5000
Gerrit-Change-Number: 14737
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 Nov 2019 22:26:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9166: undo inadvertant change testResourceRequirements

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14737 )

Change subject: IMPALA-9166: undo inadvertant change testResourceRequirements
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/14737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4791b117ddd42df2db5c01c529dd8ec850c5000
Gerrit-Change-Number: 14737
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 Nov 2019 02:58:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9166: undo inadvertant change testResourceRequirements

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14737 )

Change subject: IMPALA-9166: undo inadvertant change testResourceRequirements
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5239/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/14737
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4791b117ddd42df2db5c01c529dd8ec850c5000
Gerrit-Change-Number: 14737
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 18 Nov 2019 22:25:03 +0000
Gerrit-HasComments: No