[jira] Commented: (GERONIMO-1823) Add Embedded LDAP Server Viewer Portlet

["Gianny Damour (JIRA)" <de...@geronimo.apache.org>]

    [ http://issues.apache.org/jira/browse/GERONIMO-1823?page=comments#action_12440640 ] 
            
Gianny Damour commented on GERONIMO-1823:
-----------------------------------------

Chris, thanks for this patch. 

Just a couple of minor comments: I think that you need to update your copyright template as the date range is not correct. Also, I think that LDAPManagerHelper.main should not be there. If it is not too expensive to start-up an embedded LDAP server, then perhaps that you could implement a JUnit test for LDAPManagerHelper.

> Add Embedded LDAP Server Viewer Portlet
> ---------------------------------------
>
>                 Key: GERONIMO-1823
>                 URL: http://issues.apache.org/jira/browse/GERONIMO-1823
>             Project: Geronimo
>          Issue Type: New Feature
>      Security Level: public(Regular issues) 
>          Components: console
>    Affects Versions: 1.2
>            Reporter: Christopher M. Cardona
>         Attachments: dojo-0.3.1-bin.zip, GERONIMO-1823-trunk2.patch, ldapMgrPortlet-B1.1.1.jpg, ldapMgrPortlet-B1.1.1.patch, ldapMgrPortlet-Snapshot.zip, ldapMgrPortlet.patch, ldapviewer-jetty-1.2-SNAPSHOT.car, ldapviewer-portlet-1.2-SNAPSHOT.jpg, ldapviewer-tomcat-1.2-SNAPSHOT.car, ldapviewer-webapp-1.2-SNAPSHOT.jpg, sample.ldif
>
>
> Add a new portlet for viewing the contents of the embedded directory server (Apache DS). This portlet will be under 'Misc' portlets.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira