[jira] [Commented] (FLINK-7386) Flink Elasticsearch 5 connector is not compatible with Elasticsearch 5.2+ client

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16369365#comment-16369365 ] 

ASF GitHub Bot commented on FLINK-7386:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4675#discussion_r169139984
  
    --- Diff: flink-connectors/flink-connector-elasticsearch5.3/src/main/java/org/apache/flink/streaming/connectors/elasticsearch53/BulkProcessorIndexer.java ---
    @@ -0,0 +1,57 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.connectors.elasticsearch53;
    +
    +import org.apache.flink.streaming.connectors.elasticsearch.RequestIndexer;
    +
    +import org.elasticsearch.action.ActionRequest;
    +import org.elasticsearch.action.DocWriteRequest;
    +import org.elasticsearch.action.bulk.BulkProcessor;
    +
    +import java.util.concurrent.atomic.AtomicLong;
    +
    +/**
    + * Implementation of a {@link RequestIndexer}, using a {@link BulkProcessor}.
    + * {@link ActionRequest ActionRequests} will be converted to {@link DocWriteRequest}
    + * and will be buffered before sending a bulk request to the Elasticsearch cluster.
    + */
    +public class BulkProcessorIndexer implements RequestIndexer {
    +
    +	private final BulkProcessor bulkProcessor;
    +	private final boolean flushOnCheckpoint;
    +	private final AtomicLong numPendingRequestsRef;
    +
    +	public BulkProcessorIndexer(BulkProcessor bulkProcessor,
    +								boolean flushOnCheckpoint,
    +								AtomicLong numPendingRequests) {
    +		this.bulkProcessor = bulkProcessor;
    +		this.flushOnCheckpoint = flushOnCheckpoint;
    +		this.numPendingRequestsRef = numPendingRequests;
    +	}
    +
    +	@Override
    +	public void add(ActionRequest... actionRequests) {
    +		for (ActionRequest actionRequest : actionRequests) {
    +			if (flushOnCheckpoint) {
    +				numPendingRequestsRef.getAndIncrement();
    +			}
    +			this.bulkProcessor.add((DocWriteRequest) actionRequest);
    --- End diff --
    
    This unchecked cast makes me quite uncomfortable and contradicts the actual API. This is exactly the kind of thing that should not even be possible to fail at runtime.
    
    `elasticsearch-base` was created with the assumption that interfaces it works on are compatible across all versions used, but 5.3 violates this assumption. In fact, if you were to update the version to 5.3 things wouldn't even compile due to another incompatible change in the constructor of `BulkItemResponse`.
    
    I believe this is a case where duplicating the entire elasticsearch-base module and properly modifying the interfaces would be the appropriate solution (as either a new 5.3-base module or a completely self-contained one).


> Flink Elasticsearch 5 connector is not compatible with Elasticsearch 5.2+ client
> --------------------------------------------------------------------------------
>
>                 Key: FLINK-7386
>                 URL: https://issues.apache.org/jira/browse/FLINK-7386
>             Project: Flink
>          Issue Type: Improvement
>          Components: ElasticSearch Connector
>            Reporter: Dawid Wysakowicz
>            Assignee: Fang Yong
>            Priority: Critical
>             Fix For: 1.5.0
>
>
> In Elasticsearch 5.2.0 client the class {{BulkProcessor}} was refactored and has no longer the method {{add(ActionRequest)}}.
> For more info see: https://github.com/elastic/elasticsearch/pull/20109



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)