[GitHub] timpharo edited a comment on issue #4575: [AIRFLOW-3760] - Ensure that we pass the command to the Kubernetes Pod as a List

[GitBox <gi...@apache.org>]

timpharo edited a comment on issue #4575: [AIRFLOW-3760] - Ensure that we pass the command to the Kubernetes Pod as a List
URL: https://github.com/apache/airflow/pull/4575#issuecomment-457121093
 
 
   This breaking change is affecting us too. From what I can see and have read from the description this is a contribution back for a breaking change that was made in https://github.com/apache/airflow/pull/3740.  
   Looking through the original PR, the changes made that are causing issues with 'cmds' seems unrelated to the description of the original pull request and furthermore the original pull request doesn't have any tests, stating "Tests updated (but not functionally)".
   
   As an open source project that to my knowledge is very well used now, I find it hard to believe that this kind of thing has been merged with comments outstanding such as "The airflow command is not passed as a string anymore. I need some help in doing this properly for the k8s executor most likely".
   
   As the merge of PR 3740 broke the K8 functionality, it seems that the correct action would be to revert those changes and re-implement with better testing in place.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services