You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/11 03:39:23 UTC
[GitHub] [shardingsphere] terrymanu opened a new pull request, #20916: Refactor KernelSQLException and impls
terrymanu opened a new pull request, #20916:
URL: https://github.com/apache/shardingsphere/pull/20916
For #20036.
Changes proposed in this pull request:
- Refactor MetaDataSQLException
- Refactor DataSQLException
- Refactor SyntaxSQLException
- Refactor ConnectionSQLException
- Refactor TransactionSQLException
- Refactor LockSQLException
- Refactor CheckSQLException
- Refactor ClusterSQLException
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have triggered maven check: `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [x] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #20916: Refactor KernelSQLException and impls
Posted by GitBox <gi...@apache.org>.
tristaZero merged PR #20916:
URL: https://github.com/apache/shardingsphere/pull/20916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #20916: Refactor KernelSQLException and impls
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #20916:
URL: https://github.com/apache/shardingsphere/pull/20916#issuecomment-1242890155
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/20916?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20916](https://codecov.io/gh/apache/shardingsphere/pull/20916?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7dd4539) into [master](https://codecov.io/gh/apache/shardingsphere/commit/0e00ae0ffec9f805a44d282158f52aee7b693ce7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0e00ae0) will **decrease** coverage by `0.01%`.
> The diff coverage is `26.92%`.
```diff
@@ Coverage Diff @@
## master #20916 +/- ##
============================================
- Coverage 61.70% 61.68% -0.02%
- Complexity 2464 2465 +1
============================================
Files 4026 4034 +8
Lines 55563 55580 +17
Branches 9423 9424 +1
============================================
+ Hits 34284 34286 +2
- Misses 18398 18413 +15
Partials 2881 2881
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/20916?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../shardingsphere/infra/check/SQLCheckException.java](https://codecov.io/gh/apache/shardingsphere/pull/20916/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9jaGVjay9TUUxDaGVja0V4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ase/metadata/UnrecognizedDatabaseURLException.java](https://codecov.io/gh/apache/shardingsphere/pull/20916/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kYXRhYmFzZS9tZXRhZGF0YS9VbnJlY29nbml6ZWREYXRhYmFzZVVSTEV4Y2VwdGlvbi5qYXZh) | `100.00% <ø> (ø)` | |
| [...sphere/infra/exception/ConnectionSQLException.java](https://codecov.io/gh/apache/shardingsphere/pull/20916/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9leGNlcHRpb24vQ29ubmVjdGlvblNRTEV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ardingsphere/infra/exception/DataSQLException.java](https://codecov.io/gh/apache/shardingsphere/pull/20916/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9leGNlcHRpb24vRGF0YVNRTEV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...exception/OverallConnectionNotEnoughException.java](https://codecov.io/gh/apache/shardingsphere/pull/20916/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9leGNlcHRpb24vT3ZlcmFsbENvbm5lY3Rpb25Ob3RFbm91Z2hFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...dingsphere/infra/exception/SyntaxSQLException.java](https://codecov.io/gh/apache/shardingsphere/pull/20916/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9leGNlcHRpb24vU3ludGF4U1FMRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...gsphere/infra/lock/exception/LockSQLException.java](https://codecov.io/gh/apache/shardingsphere/pull/20916/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9sb2NrL2V4Y2VwdGlvbi9Mb2NrU1FMRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../lock/exception/TableLockWaitTimeoutException.java](https://codecov.io/gh/apache/shardingsphere/pull/20916/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9sb2NrL2V4Y2VwdGlvbi9UYWJsZUxvY2tXYWl0VGltZW91dEV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ere/infra/lock/exception/TableLockedException.java](https://codecov.io/gh/apache/shardingsphere/pull/20916/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9sb2NrL2V4Y2VwdGlvbi9UYWJsZUxvY2tlZEV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...n/UnsupportedActualDataNodeStructureException.java](https://codecov.io/gh/apache/shardingsphere/pull/20916/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhYmFzZS9zY2hlbWEvZXhjZXB0aW9uL1Vuc3VwcG9ydGVkQWN0dWFsRGF0YU5vZGVTdHJ1Y3R1cmVFeGNlcHRpb24uamF2YQ==) | `0.00% <ø> (ø)` | |
| ... and [40 more](https://codecov.io/gh/apache/shardingsphere/pull/20916/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org