You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/08/07 03:54:00 UTC
[jira] [Commented] (IMPALA-10053) Remove uses of
MonoTime::GetDeltaSince()
[ https://issues.apache.org/jira/browse/IMPALA-10053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17172801#comment-17172801 ]
ASF subversion and git services commented on IMPALA-10053:
----------------------------------------------------------
Commit 7a6469e44486191cd344e9f7dcf681763d6091db in impala's branch refs/heads/master from Thomas Tauber-Marshall
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=7a6469e ]
IMPALA-10053: Remove uses of MonoTime::GetDeltaSince()
MonoTime is a utility Impala imports from Kudu. The behavior of
MonoTime::GetDeltaSince() was accidentally flipped in
https://gerrit.cloudera.org/#/c/14932/ so we're getting negative
durations where we expect positive durations.
The function is deprecated anyways, so this patch removes all uses of
it and replaces them with the MonoTime '-' operator.
Testing:
- Manually ran with and without patch and inspected calculated values.
- Added DCHECKs to prevent sucn an issue from occurring again.
Change-Id: If8cd3eb51a4fd101bbe4b9c44ea9be6ea2ea0d06
Reviewed-on: http://gerrit.cloudera.org:8080/16296
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> Remove uses of MonoTime::GetDeltaSince()
> ----------------------------------------
>
> Key: IMPALA-10053
> URL: https://issues.apache.org/jira/browse/IMPALA-10053
> Project: IMPALA
> Issue Type: Task
> Affects Versions: Impala 4.0, Impala 3.4.0
> Reporter: Thomas Tauber-Marshall
> Assignee: Thomas Tauber-Marshall
> Priority: Major
>
> MonoTime is a utility Impala imports from Kudu. The behavior of MonoTime::GetDeltaSince() was accidentally flipped in https://gerrit.cloudera.org/#/c/14932/ so we're getting negative durations where we expect positive durations.
> The function is deprecated anyways, so we should remove all uses of it.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org