[jira] Commented: (QPID-1952) C++: client request memory leak on windows

["Steve Huston (JIRA)" <qp...@incubator.apache.org>]

    [ https://issues.apache.org/jira/browse/QPID-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12725670#action_12725670 ] 

Steve Huston commented on QPID-1952:
------------------------------------

The patch adds a call to queueForDeletion, but close() already calls that. I think there may be an issue with a queued delete not taking effect later. I'll check into that a bit. If you have any insight into this area from your debugging, that would be helpful too.
Thanks.

> C++: client request memory leak on windows
> ------------------------------------------
>
>                 Key: QPID-1952
>                 URL: https://issues.apache.org/jira/browse/QPID-1952
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Client
>    Affects Versions: 0.5
>         Environment: Windows XP Pro w/SP3
>            Reporter: David Rennalls
>         Attachments: Connector_memory_leak.patch, Main2.cpp
>
>
> I'm experiencing a memory leak when using the client library on Windows (0.5 release) when sending a single request. From what debugging I've done so far it looks like the The AsynchIO object used by the TCPConnector is not being deleted.  When the connection is being closed aio->queueForDeletion() is called from TCPConnector::closeInternal().. However in AsynchIO::queueForDeletion() aio.opsInProgress > 0 so the 'delete this' branch is not done. There are no more queueForDeletion() calls made on the aio object (after opsInProgress is 0) and so it never gets deleted. The ConnectionImpl object involved is not cleaned up either, the shared_ptr to it has a non-zero ref count but I'm guessing it's related to the AsynchIO object not being cleaned up.
> There used to be some code in AsynchIO::completion() that seems like it would do the necessary delete (see below). It was removed with code changes in https://issues.apache.org/jira/browse/QPID-1550 because 'It fixed a memory corruption on the broker side by deleting too early' (from Steve H.)
> -    // Lock released; ok to delete if all is done.
> -    if (opsInProgress == 0 && queuedDelete)
> -        delete this;

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org