[jira] [Commented] (FELIX-3737) HttpFilter service.ranking is not evaluated properly under some circumstances

["Felix Meschberger (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-3737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484901#comment-13484901 ] 

Felix Meschberger commented on FELIX-3737:
------------------------------------------

Thanks for reporting.

Fixed in Rev. 1402499. Can you confirm it works for your ? Thanks.
                
> HttpFilter service.ranking is not evaluated properly under some circumstances
> -----------------------------------------------------------------------------
>
>                 Key: FELIX-3737
>                 URL: https://issues.apache.org/jira/browse/FELIX-3737
>             Project: Felix
>          Issue Type: Bug
>          Components: HTTP Service
>    Affects Versions: http-2.2.0
>            Reporter: Philipp Marx
>            Assignee: Felix Meschberger
>            Priority: Minor
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> If a Http-Filter is registered with a service.ranking of Interger.MAX_VALUE and another Http-Filter is registered with a negative service.ranking (like org.apache.sling.i18n.impl.I18NFilter which has -700) the evaluation of the sorting order (mostly) fails.
> The problem is FilterHandler's compareTo method which leads to an overflow in this case:
>  public int compareTo(FilterHandler other)
>  {
>      return other.ranking - this.ranking;
>  }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira